Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle edge case where menu is not defined. #804

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

timcosgrove
Copy link
Contributor

@timcosgrove timcosgrove commented Nov 4, 2024

Description

These changes handle an edge case where a facility-connected page does not have an active VAMC system; see more details in the ticket.

Ticket

department-of-veterans-affairs/va.gov-cms#19759

Developer Task

Tasks

Preview Give feedback

QA steps

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

Tasks

Preview Give feedback

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 4, 2024 21:11 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 4, 2024 21:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 4, 2024 22:17 Destroyed
entity.field_office.field_system_menu.resourceIdObjMeta
.drupal_internal__target_id
)
let menu = null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These match what was already in events.

Copy link

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@timcosgrove timcosgrove merged commit e658209 into main Nov 5, 2024
10 checks passed
@timcosgrove timcosgrove deleted the patch_facility_menus branch November 5, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants