Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Design System dependencies to latest #812

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Nov 14, 2024

Description

Updates the design system dependencies to their latest versions.

Tested against the existing /outreach-and-events/events page and an event detail page.

component-library release notes: https://github.com/department-of-veterans-affairs/component-library/releases

Ticket

Relates to #19386.

Developer Task

Tasks

Preview Give feedback

Testing Steps

Regression check Events search and detail pages against what is currently in dev.

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Screenshots

Events search page

Desktop
Before (dev.va.gov) After (local)
Screenshot 2024-11-14 at 4 51 30 PM Screenshot 2024-11-14 at 4 51 21 PM
Screenshot 2024-11-14 at 4 52 02 PM Screenshot 2024-11-14 at 4 51 53 PM
Tablet
Before (dev.va.gov) After (local)
Screenshot 2024-11-14 at 4 52 39 PM Screenshot 2024-11-14 at 4 52 32 PM
Mobile
Before (dev.va.gov) After (local)
Screenshot 2024-11-14 at 4 53 01 PM Screenshot 2024-11-14 at 4 52 56 PM

Events detail page

Tested /central-western-massachusetts-health-care/events/73034

Desktop
Before (dev.va.gov) After (local)
Screenshot 2024-11-14 at 4 54 25 PM Screenshot 2024-11-14 at 4 54 18 PM
Screenshot 2024-11-14 at 4 55 05 PM Screenshot 2024-11-14 at 4 54 46 PM
Screenshot 2024-11-14 at 4 55 39 PM Screenshot 2024-11-14 at 4 55 32 PM
Tablet
Before (dev.va.gov) After (local)
Screenshot 2024-11-14 at 4 54 06 PM Screenshot 2024-11-14 at 4 53 59 PM
Mobile
Before (dev.va.gov) After (local)
Screenshot 2024-11-14 at 4 53 39 PM Screenshot 2024-11-14 at 4 53 31 PM

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

Tasks

Preview Give feedback

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 14, 2024 23:01 Destroyed
@randimays randimays marked this pull request as ready for review November 14, 2024 23:11
@timcosgrove timcosgrove merged commit b560102 into Sitewide-integration Nov 14, 2024
8 checks passed
@timcosgrove timcosgrove deleted the update-ds-dependencies branch November 14, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants