Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics] [Social media links] Custom and Duplicate GA events removal #18522

Closed
5 tasks
randimays opened this issue Jul 16, 2024 · 1 comment
Closed
5 tasks
Assignees
Labels
Dupe Events Removal Insights & analytics CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@randimays
Copy link
Contributor

randimays commented Jul 16, 2024

Status

[2024-07-23] [Fran] Duplicative events need to be removed. This ticket should be prioritized.

Description

The va-link web component's analytics now include link destination, and va-link-action has been released to the component library. We can now use baked-in analytics and convert to web components where possible in social media sidebar links.

Engineering notes

Some exploration will need to be done to discover where this file / sidebar is used and how it differs from the sidebars present on benefit hub detail pages.

Code:

User story

AS A PO/PM managing Sitewide products & features
I WANT to (where appropriate) adopt the va-link or va-link-action component, its baked-in analytics, and remove the custom GA events
SO THAT extraneous code is removed and only the events needed will be triggered.

Acceptance criteria

  • Element: Social media links (all four instances in src/site/components/merger-social-sco.html)
    • remove custom events
    • enable component's baked-in analytics
    • remove duplicate events
  • a11y review
@randimays
Copy link
Contributor Author

Code has been merged to production. Verified that only the web component baked-in analytics are firing now. Closing as complete

@FranECross FranECross changed the title [Analytics] [Social media links] Custom GA events removal [Analytics] [Social media links] Custom and Duplicate GA events removal Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dupe Events Removal Insights & analytics CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

2 participants