QA test plan for: Drupal Phone Number Work

[Agile6MSkinner]

Testing context

Implementation ticket being tested:
#17860
#17861
#17862

What are we testing?

We are testing the migration of the data, which splits all existing phone numbers into phone and extension fields. We also looking at the editor interface to make sure that data entry meets ACs

Testing environment

• TB - One branch on tugboat that has all three Drupal changes.

Scope of changes: high level

Change from a field to a paragraph type for phone number entry in three content types: Billing & Insurance, Staff Profiles and VAMC System.

Daily Reset

Tugboat refreshes each night, and so each day the migrations need to be re-run prior to testing. Additionally, each day there is at least one change to the composer dependencies, and this makes a merge conflict with our branch. So we need engineering to "refresh" the branch each morning, followed then by someone running the below scripts:

Note: We'll need to have Platform CMS (or someone with prod shell access) execute these scripts for us when we go to prod

Running MIgrations

1. Go to the Tugboat Terminal
2. Run each command below separately.
3. Total migration time should be 30-40 minutes.

time drush codit-batch-operations:run MigratePhoneFieldToParagraph
time drush codit-batch-operations:run MigrateVamcBillingInsurancePhoneFieldToParagraph
time drush codit-batch-operations:run MigrateVamcFacilityMentalHealthPhoneFieldToParagraph

How to test migration

1. Go to Phone number audit view in Drupal
2. OPTIONAL: Filter by content type (it might be easier to review the migration one content type at a time):
   1. Staff Profile
   2. VAMC Billing and Insurance
   3. VAMC Facility
3. Compare the phone number information in the original field to the new field
   1. Direct line > Staff Profile Phone
   2. Mental Health Phone > {Name of new field}
   3. Direct line > {Name of new field}

Original phone number information should be migrated following these rules:

1. No non-numerical characters should be included in the Ext field
2. If multiple phone numbers were included in the original phone number field, the 1st phone number is the number that is migrated, the second number is dropped
3. Vanity numbers are ignored and instead the equivalent, numerical phone number is used in the migration (regardless of the order they are entered in the original field)

Examples:

• If original phone number has ext to denote extension:
  • Example: 718-584-9000, ext. 4400
  • Then, the phone number should be migrated as:
    • Phone: 718-584-9000
    • Ext: 4400
• If original phone number has x to denote extension:
  • Example: 205-933-8101 x4737
  • Then, the phone number should be migrated as:
    • Phone: 205-933-8101
    • Ext: 4737
• If original phone number has no extension:
  • Example: +1-918-781-5678
  • Then, the phone number should be migrated as:
    • Phone: 918-781-5678
    • Ext: null
• If original phone number is a vanity number:
  • Example: 888-GIBILL-1 (888-442-4551)
  • Then, the phone number should be migrated as:
    • Phone: 888-442-4551
    • Ext: null
• If original phone number contains multiple phone numbers with extension:
  • Example: 602-277-5551, ext. 2173 or 800-554-7174 (toll free)
  • Then, the phone number should be migrated as:
  • Phone: 602-277-5551
  • Ext: 2173

How to test the Content Types

User role to spoof

• VAMC content creator

Content types to check

• Staff profile
• VAMC System Billing and Insurance
• VAMC Facility - Mental health phone number

What to look for

• Toggle off - old fields show as expected, new fields are hidden
• Toggle on - new fields show as expected, old fields are hidden
• Verify the UI is updated from phone number field to phone paragraph
• Verify the label field is hidden on the content type
• Verify that validations within the phone paragraph type work as expected

Scenarios to test

• Node edit
  • Save as draft
  • Save as published
• Node view
• Node create
• A node that has a latest revision that differs from current revision pre-migration
• Nodes that have no data in the phone number field pre-migration (null)
• Telephone number with no ext
• Telephone number with ext

Acceptance Criteria / Ownership

• Schedule QA call to discuss implementation / testing needs with code author, PM, a11y, and design as needed
• Run test cases in the noted Testing environment
  • Note failures in the spreadsheet and point to either a GH ticket or a Mural to demonstrate what you found

[jilladams]

@Agile6MSkinner @dsasser should this get pulled into Sprint 12? Not sure where we landed on that. I guess pending the destiny of the 3rd phone # ticket?

[laflannery]

@dsasser I took a pass at the How to test section, using the test cases we discussed. Feel free to edit however you want

[dsasser]

End of Sprint Update 9-30-24

QA started today but in doing so we (Christian and I) noticed a static analysis error reported by PHPStan which I'm looking into. It appears to be a minimal required code change to remove some JetBrains class references. I expect to complete this QA work tomorrow.

[mmiddaugh]

@dsasser I'm peeking at the audit report in tugboat as linked in the How to test section of the description. Most of the many, many numbers in this audit look solid! 🎉

• Ocala VA Clinic - the Mental health number for this location is entered as 352-369-3320, ext. 31-6281OR31-6282 but appears to be migrated as 352-369-3320, ext. 31 which seems to have lost four digits of the extension - this is an odd case - I just don't want us to lose it if the editor has some action required

---

A few other questions (and please forgive me if I'm forgetting the plan)

• Gene Taylor Veterans' Outpatient Clinic (and others) have local or toll free bits in their main numbers - 417-891-4800, Toll Free: 844-501-8387- are they coming in from Lighthouse/VAST this way and what will happen after this change?

---

• a handful of Mental health numbers have "press, etc" numbers without a value in the new column - are these being handled separately? Examples:
  • Brownsville VA Clinic - 855-864-0516press2thenpress5
  • Corpus Christi VA Mobile Clinic and Corpus Christi West Point VA Clinic- 855-864-0516press2thenpress5

---

• will locations like Garden of the Gods VA Clinic lose their specific "choose option" instructions? 719-327-5660 (option 2 then option 4)

---

• main numbers aren't represented in this view but I assume they will be handled similarly?

[dsasser]

@mmiddaugh thank you for the quick review and subsequent questions. I'll do my best to respond to each, but there may be a product level answer to some of these:

Ocala VA Clinic - the Mental health number for this location is entered as 352-369-3320, ext. 31-6281OR31-6282 but appears to be migrated as 352-369-3320, ext. 31 which seems to have lost four digits of the extension - this is an odd case - I just don't want us to lose it if the editor has some action required

Yes I believe the algorythm drops chracters that are not integers from the extension. I'm not sure there is a way to override that but I can look into it, or we can find a way to flag these odd cases and handle them manually. Interestingly, the FE is displaying the extension as 31 today.

Gene Taylor Veterans' Outpatient Clinic (and others) have local or toll free bits in their main numbers - 417-891-4800, Toll Free: 844-501-8387- are they coming in from Lighthouse/VAST this way and what will happen after this change?

The phone number was specified to have a standard of 10 digits only. I'm not sure of the origin but the "Toll Free: 844-501-8387" portion of the old number but it would not move to the new system in order to meet this requirement, and we would need to flag this for manual follow-up. That said, this is another case where the FE is displaying the number as specified under this ticket (ie: it is removing the toll free bits)

Brownsville VA Clinic - 855-864-0516press2thenpress5
Corpus Christi VA Mobile Clinic and Corpus Christi West Point VA Clinic- 855-864-0516press2thenpress5

Yes this again was intentional to meet the requirements of this ticket, and the FE isn't displaying that text either:

main numbers aren't represented in this view but I assume they will be handled similarly?

That is my assumption as well but I haven't looked to be sure, but I'm sure @Agile6MSkinner could probably point us to those tickets if they exist.

[Agile6MSkinner]

We don't have any tickets as part of this epic that would impact how the Main Number is entered or displayed.

[davidmpickett]

We don't have any tickets as part of this epic that would impact how the Main Number is entered or displayed.

Only caveat is that we do have a placeholder ticket for considering whether we to ever migrate non-editable phone number fields to the Phone Number paragraph type. The VAMC facility main number is listed there as an example of such a type

#17864

[dsasser]

QA Findings

I found that almost all the numbers and extensions migrated as expected, with the following notable exceptions.

1. Extensions with a leading "ex:" are dropped
   An extension that begins with "ex:" will be dropped, leaving no extension migrated. I found only one instance of this in the database, so we can manually correct this during release rather than address is programatically.

2. Some phone numbers are not migrated
   There are instances of phone numbers not being "detected" as phone numbers, and therefore they are not migrated. Some example phones include:

• 845 831 2000 217666
• 855-864-0516press2thenpress5
• 909-583-6164or909-825-7084, ext. 6164

That these weren't picked up as valid phones makes sense to me, but we lack any logging/flagging mechanism, so we don't know every occurrence of this problem, only those that were picked up during QA. Adding logging would be a small lift and I think worth it so we understand the full scope of the problem.

[davidmpickett]

Noting from scrum: I am going to tear this to pieces. But waiting for @dsasser to give me a green light after stuff is rebuilt.

I will also document my intentions before tearing it apart so we can make sure it is comprehensive @jilladams

[dsasser]

Missing Migrated Phone Numbers

Per scrum we decided that for my QA results, we would do the following:

• For 1 we will manually correct this. todo->needs to be added to the launch plan.
• For 2 we wanted to know the extent of the problem so we opted to create a one-off View (report) that filters on the necessary fields. I have done this locally, and that report result is below.

Nodes with non-migratable phone numbers:

Staff Profile -> 38 nodes
VAMC Facility -> 24 nodes
VAMC System Billing and Insurance -> 0

Total nodes affected = 62 Nodes

Report Details

Node Title	Nid	Link	Type	Date	Status	Section	Bad Number
Brownsville VA Clinic	63084	Edit	VAMC Facility	10/08/2024 - 5:50 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
Corpus Christi VA Mobile Clinic	56777	Edit	VAMC Facility	10/08/2024 - 5:50 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
Corpus Christi West Point VA Clinic	51869	Edit	VAMC Facility	10/08/2024 - 5:50 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
McAllen VA Mobile Clinic	2315	Edit	VAMC Facility	10/08/2024 - 5:49 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
Laredo VA Clinic	2311	Edit	VAMC Facility	10/08/2024 - 5:49 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
South Enterprize VA Clinic	2312	Edit	VAMC Facility	10/08/2024 - 5:49 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
Corpus Christi VA Clinic	2310	Edit	VAMC Facility	10/08/2024 - 5:49 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
McAllen VA Clinic	2309	Edit	VAMC Facility	10/08/2024 - 5:49 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
Harlingen VA Clinic-Treasure Hills	2308	Edit	VAMC Facility	10/08/2024 - 5:49 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
Harlingen VA Clinic	2307	Edit	VAMC Facility	10/08/2024 - 5:49 pm	Published	VA Texas Valley health care	855-864-0516press2thenpress5
LaGrange VA Clinic	2224	Edit	VAMC Facility	10/08/2024 - 5:48 pm	Published	VA Central Texas health care	254-743-2867option3
Temple VA Clinic	2223	Edit	VAMC Facility	10/08/2024 - 5:48 pm	Published	VA Central Texas health care	254-743-2867option1
Bryan VA Clinic	2221	Edit	VAMC Facility	10/08/2024 - 5:48 pm	Published	VA Central Texas health care	254-743-2867option3
Brownwood VA Clinic	2220	Edit	VAMC Facility	10/08/2024 - 5:48 pm	Published	VA Central Texas health care	254-743-2867option3
Palestine VA Clinic	2219	Edit	VAMC Facility	10/08/2024 - 5:48 pm	Published	VA Central Texas health care	254-743-2867option3
West Lakeland VA Clinic	2206	Edit	VAMC Facility	10/08/2024 - 5:48 pm	Published	VA Tampa health care	863-701-2470press4
Zephyrhills VA Clinic	2201	Edit	VAMC Facility	10/08/2024 - 5:48 pm	Published	VA Tampa health care	863-701-2470press4
Staunton VA Clinic	2106	Edit	VAMC Facility	10/08/2024 - 5:47 pm	Published	VA Salem health care	540-886-5777option2
Wytheville VA Clinic	2107	Edit	VAMC Facility	10/08/2024 - 5:47 pm	Published	VA Salem health care	276-223-5400option2
Lynchburg VA Clinic	2105	Edit	VAMC Facility	10/08/2024 - 5:47 pm	Published	VA Salem health care	434-316-5000option2
Danville VA Clinic	2104	Edit	VAMC Facility	10/08/2024 - 5:47 pm	Published	VA Salem health care	434-710-4210option1
Lyle C. Pearson Community Based Outpatient Clinic	1820	Edit	VAMC Facility	10/08/2024 - 5:44 pm	Published	VA Minneapolis health care	507-387-2939option4
Jerry L. Pettis Memorial Veterans' Hospital	1746	Edit	VAMC Facility	10/08/2024 - 5:43 pm	Published	VA Loma Linda health care	909-583-6164or909-825-7084, ext. 6164
Florence VA Clinic	1407	Edit	VAMC Facility	10/08/2024 - 5:40 pm	Published	VA Columbia South Carolina health care	803-776-4000-55266
Roderick McNeil	72333	Edit	Staff Profile	10/08/2024 - 5:20 pm	Published	VA Dublin health care	478-27-1210
Jung Lee	70496	Edit	Staff Profile	10/08/2024 - 5:19 pm	Published	VA Columbia Missouri health care	(573)814-600 x52202
Hugo Martinez	69630	Edit	Staff Profile	10/08/2024 - 5:18 pm	Published	VA Texas Valley health care	95-291-9243
Lisa M Ryder	66466	Edit	Staff Profile	10/08/2024 - 5:16 pm	Published	VA Long Beach health care	562-826-8000-1 ext. 4321
Timothy Nason	65143	Edit	Staff Profile	10/08/2024 - 5:15 pm	Published	VA Salisbury health care	704-638-900 ext. 15502
Robert Julian	64939	Edit	Staff Profile	10/08/2024 - 5:15 pm	Published	VA Saginaw health care	13050
Brittany Bays	64663	Edit	Staff Profile	10/08/2024 - 5:15 pm	Published	VA Huntington health care	2268
Patricia Ferguson	64664	Edit	Staff Profile	10/08/2024 - 5:15 pm	Published	VA Huntington health care	2268
Crystal Peruski	64419	Edit	Staff Profile	10/08/2024 - 5:15 pm	Published	VA Saginaw health care	13031
Mary Newell	63667	Edit	Staff Profile	10/08/2024 - 5:14 pm	Published	VA Cheyenne health care	970-013-2818
Mary Newell	63666	Edit	Staff Profile	10/08/2024 - 5:14 pm	In review	VA Cheyenne health care	970-013*2818
Adam Swager	62696	Edit	Staff Profile	10/08/2024 - 5:13 pm	Published	VA Battle Creek health care	(269) 2223-6212
Deleter Delete	61966	Edit	Staff Profile	10/08/2024 - 5:13 pm	Published	VA Columbia South Carolina health care	Delete
Erica Chiado	58577	Edit	Staff Profile	10/08/2024 - 5:11 pm	Published	VA Roseburg health care	45352
Daniel Neppel	55347	Edit	Staff Profile	10/08/2024 - 5:10 pm	Archived	VA Iowa City health care	(319) 338-0581 636132
Jane Doe	55156	Edit	Staff Profile	10/08/2024 - 5:09 pm	Published	VA Indiana health care	555-555-5555
John Doe	55157	Edit	Staff Profile	10/08/2024 - 5:09 pm	Published	VA Indiana health care	555-555-5555
Nicolas Bu-Saba	48096	Edit	Staff Profile	10/08/2024 - 5:03 pm	Published	VA Boston health care	857-364-43660
Walter Figueroa	47844	Edit	Staff Profile	10/08/2024 - 5:02 pm	Published	VA Dublin health care	278-272-1210 ext. 72729
Alicia Miller	46929	Edit	Staff Profile	10/08/2024 - 5:01 pm	Published	VA Wichita health care	Ext. 53613
Jed Ferguson	46137	Edit	Staff Profile	10/08/2024 - 5:01 pm	Published	VA Birmingham health care	[email protected]
Ryan M. Stubblebine	44777	Edit	Staff Profile	10/08/2024 - 5:00 pm	Published	VA Lebanon health care	ext. 6856
June Griffith	42236	Edit	Staff Profile	10/08/2024 - 4:58 pm	Published	VA Tuscaloosa health care	2052-554-2000 ext: 3856
Kristi Green	38878	Edit	Staff Profile	10/08/2024 - 4:57 pm	Archived	VA Walla Walla health care	509-525=5200
Gary Shepherd	38210	Edit	Staff Profile	10/08/2024 - 4:57 pm	Archived	VA Huntington health care	2268
Jessica L. Mathis	38214	Edit	Staff Profile	10/08/2024 - 4:57 pm	Archived	VA Huntington health care	2268
Aaron Carson	35946	Edit	Staff Profile	10/08/2024 - 4:55 pm	Archived	VA Fayetteville Arkansas health care	479-44-4301 ext. 65175
Lenox Okall	34079	Edit	Staff Profile	10/08/2024 - 4:55 pm	Published	VA Hudson Valley health care	Ext. 217721
Melissa Steininger	33107	Edit	Staff Profile	10/08/2024 - 4:54 pm	Published	VA Albany health care	(518) 641-NEWS (6397)
Capitol Region News Room Spectrum News	33105	Edit	Staff Profile	10/08/2024 - 4:54 pm	Published	VA Albany health care	(518) 641-NEWS (6397)
Jeffery Reed	18607	Edit	Staff Profile	10/08/2024 - 4:52 pm	Published	VA Northern Indiana health care	260-426-54313321, ext. 61340
Lora Gilliland	18418	Edit	Staff Profile	10/08/2024 - 4:51 pm	Published	VA Chillicothe health care	740.773.1141...17640
George Velez	16027	Edit	Staff Profile	10/08/2024 - 4:47 pm	Archived	VA Caribbean health care	135915
Carlos R. Escobar	16026	Edit	Staff Profile	10/08/2024 - 4:47 pm	Published	VA Caribbean health care	135913
Asha Vallamattam	11646	Edit	Staff Profile	10/08/2024 - 4:46 pm	Published	VA Hudson Valley health care	845 831 2000 217666
Jorden Donner	11532	Edit	Staff Profile	10/08/2024 - 4:45 pm	Published	VA Fargo health care	701-239-370 Ext. 4389
Jeffrey S. Morgan	11147	Edit	Staff Profile	10/08/2024 - 4:44 pm	Archived	VA Fayetteville Coastal health care	910-88-2120 ext. 6590
Douglas L. Wagner	2483	Edit	Staff Profile	10/08/2024 - 4:43 pm	Published	VA Lebanon health care	ext. 5866

@Agile6MSkinner @jilladams @davidmpickett @FranECross

[davidmpickett]

Nice to see that the majority of these are at least human parsable to determine intent.

IMO we could do some bulk updates to clean a bunch of these up in Prod with a revision message like "Updated phone number formatting." For instance the first 10 of these are showing on prod as already clipped to the phone number, so there would be zero impact to Veterans if we chop off the trailing bits.

I'm willing to go in and do some data cleanup tomorrow so we can whittle this list down to ones that will truly require editor outreach.

@Agile6MSkinner @mmiddaugh let me know if I have a green light to do that

[davidmpickett]

we opted to create a one-off View (report) that filters on the necessary fields. I have done this locally, and that report result is below.

@dsasser I assume you'll save that configuration somewhere so we can run that report again after launch?

[laflannery]

The DS component supports multiple extensions and I have tested to confirm it works. Basically the phone dials the main number, pauses, dials the first extension, pauses, then dials the second.

So for a phone number such as 855-864-0516press2thenpress5 If 2,5 were entered into the extension prop of the component it would work properly:

Knowing this is a use case, perhaps we want to consider this and allow commas in the extension field?

[dsasser]

The DS component supports multiple extensions and I have tested to confirm it works. Basically the phone dials the main number, pauses, dials the first extension, pauses, then dials the second.

So for a phone number such as 855-864-0516press2thenpress5 If 2,5 were entered into the extension prop of the component it would work properly:

Knowing this is a use case, perhaps we want to consider this and allow commas in the extension field?

I would be hesitant to change the migration's logic at this point to account for extracting multiple extensions because of how messy that would get in the codebase. I'm all for allowing the comma in the field for editors however.

[laflannery]

@dsasser definitely agree with not changing the migration. We can handle this manually and with guidance if we choose to do anything with this info.

[davidmpickett]

Notes on manual clean up

@dsasser @mmiddaugh @Agile6MSkinner I have completed my manual data clean up

Fixed, no follow up needed

26 nodes

Node Title	Nid	Section	Bad Number	Changed to	Follow Up
Roderick McNeil	72333	VA Dublin health care	478-27-1210	478-272-1210	N/A
Jung Lee	70496	VA Columbia Missouri health care	(573)814-600 x52202	573-814-600 x52202	N/A
Hugo Martinez	69630	VA Texas Valley health care	95-291-9243	956-291-9243	N/A
Lisa M Ryder	66466	VA Long Beach health care	562-826-8000-1 ext. 4321	562-826-8000 ext. 4321	N/A
Timothy Nason	65143	VA Salisbury health care	704-638-900 ext. 15502	704-638-900 x15502	N/A
Robert Julian	64939	VA Saginaw health care	13050	989-497-2500 x13050	N/A
Brittany Bays	64663	VA Huntington health care	2268	304-429-6741 x2268	N/A
Patricia Ferguson	64664	VA Huntington health care	2268	304-429-6741 x2268	N/A
Crystal Peruski	64419	VA Saginaw health care	13031	989-497-2500 x13031	N/A
Nicolas Bu-Saba	48096	VA Boston health care	857-364-43660	857-364-3660	N/A
Walter Figueroa	47844	VA Dublin health care	278-272-1210 ext. 72729	278-272-1210 x72729	N/A
Alicia Miller	46929	VA Wichita health care	Ext. 53613	316-685-2221 x53613	N/A
Jed Ferguson	46137	VA Birmingham health care	[email protected]	Moved to email field	N/A
Ryan M. Stubblebine	44777	VA Lebanon health care	ext. 6856	717-272-6621 x6856	N/A
June Griffith	42236	VA Tuscaloosa health care	2052-554-2000 ext: 3856	205-554-2000 x3856	N/A
Carlos R. Escobar	16026	VA Caribbean health care	135913	787-641-7582 x135913	N/A
Asha Vallamattam	11646	VA Hudson Valley health care	845 831 2000 217666	845-831-2000 x217666	N/A
Jorden Donner	11532	VA Fargo health care	701-239-370 Ext. 4389	701-239-3700 x4389	N/A
Lenox Okall	34079	VA Hudson Valley health care	Ext. 217721	845-831-2000 x217721	N/A
Melissa Steininger	33107	VA Albany health care	(518) 641-NEWS (6397)	(518) 641-6397	N/A
Capitol Region News Room Spectrum News	33105	VA Albany health care	(518) 641-NEWS (6397)	(518) 641-6397	N/A
Jeffery Reed	18607	VA Northern Indiana health care	260-426-54313321, ext. 61340	260-426-5431 x61340	N/A
Lora Gilliland	18418	VA Chillicothe health care	740.773.1141...17640	740-773-1141 x17640	N/A
Douglas L. Wagner	2483	VA Lebanon health care	ext. 5866	717-272-6621 x5866	N/A
Erica Chiado	58577	VA Roseburg health care	45352	541-440-1000 x45352	N/A
Adam Swager	62696	VA Battle Creek health care	(269) 2223-6212	269-2223-6212	N/A

Possible follow up action

24 nodes

Node Title	Nid	Section	Bad Number	Changed to	Follow Up
Brownsville VA Clinic	63084	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
Corpus Christi VA Mobile Clinic	56777	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
Corpus Christi West Point VA Clinic	51869	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
McAllen VA Mobile Clinic	2315	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
Laredo VA Clinic	2311	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
South Enterprize VA Clinic	2312	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
Corpus Christi VA Clinic	2310	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
McAllen VA Clinic	2309	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
Harlingen VA Clinic-Treasure Hills	2308	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
Harlingen VA Clinic	2307	VA Texas Valley health care	855-864-0516press2thenpress5	855-864-0516	Consider ext 2,5
LaGrange VA Clinic	2224	VA Central Texas health care	254-743-2867option3	254-743-2867	Consider ext 3
Temple VA Clinic	2223	VA Central Texas health care	254-743-2867option1	254-743-2867	Consider ext 1
Bryan VA Clinic	2221	VA Central Texas health care	254-743-2867option	254-743-2867	Consider ext 3
Brownwood VA Clinic	2220	VA Central Texas health care	254-743-2867option3	254-743-2867	Consider ext 3
Palestine VA Clinic	2219	VA Central Texas health care	254-743-2867option3	254-743-2867	Consider ext 3
West Lakeland VA Clinic	2206	VA Tampa health care	863-701-2470press4	Updating phone number format	Consider ext 4
Zephyrhills VA Clinic	2201	VA Tampa health care	863-701-2470press4	Updating phone number format	Consider ext 4
Staunton VA Clinic	2106	VA Salem health care	540-886-5777option2	540-886-5777	Consider ext 2
Wytheville VA Clinic	2107	VA Salem health care	276-223-5400option2	276-223-5400	Consider ext 2
Lynchburg VA Clinic	2105	VA Salem health care	434-316-5000option2	434-316-5000	Consider ext 2
Danville VA Clinic	2104	VA Salem health care	434-710-4210option1	434-710-4210	Consider ext 1
Lyle C. Pearson Community Based Outpatient Clinic	1820	VA Minneapolis health care	507-387-2939option4	507-387-2939	Consider ext 4
Jerry L. Pettis Memorial Veterans' Hospital	1746	VA Loma Linda health care	909-583-6164or909-825-7084, ext. 6164	909-583-6164	Confirm that this is the preferred number.
Florence VA Clinic	1407	VA Columbia South Carolina health care	803-776-4000-55266	803-776-4000	Consider ext 55266

Will be null after migration and that's okay!

11 nodes

Node Title	Nid	Section	Bad Number	Changed to	Follow Up
Mary Newell	63666	VA Cheyenne health care	970-013*2818	N/A	Unpublished duplicate = okay to go null
Deleter Delete	61966	VA Columbia South Carolina health care	Delete	N/A	Not a phone number = okay to go null
Daniel Neppel	55347	VA Iowa City health care	(319) 338-0581 636132	N/A	Archived = okay to go null
Jane Doe	55156	VA Indiana health care	555-555-5555	N/A	Not a real phone number = okay to go null
John Doe	55157	VA Indiana health care	555-555-5555	N/A	Not a real phone number = okay to go null
Kristi Green	38878	VA Walla Walla health care	509-525=5200	N/A	Archived = okay to go null
Gary Shepherd	38210	VA Huntington health care	2268	N/A	Archived = okay to go null
Jessica L. Mathis	38214	VA Huntington health care	2268	N/A	Archived = okay to go null
Aaron Carson	35946	VA Fayetteville Arkansas health care	479-44-4301 ext. 65175	N/A	Archived = okay to go null
George Velez	16027	VA Caribbean health care	135915	N/A	Archived = okay to go null
Jeffrey S. Morgan	11147	VA Fayetteville Coastal health care	910-88-2120 ext. 6590	N/A	Archived = okay to go null

Needs editor outreach

1 node

Node Title	Nid	Section	Bad Number	Changed to	Follow Up
Mary Newell	63667	VA Cheyenne health care	970-013-2818	N/A	Not a valid phone number, no obvious typo based on review of other Cheyenne VAMC phone numbers. Needs editor outreach

[omahane]

@davidmpickett According to https://en.wikipedia.org/wiki/North_American_Numbering_Plan, the Central office code, the "456" of 123-456-7890, has to start with numbers 2-9, rather than 0.

[davidmpickett]

Thanks @omahane. I updated my chart to reflect that insight. We'll definitely need the editor to fix the phone number. I wasn't able to find an obvious typo I could fix when comparing to other Cheyenne VAMC numbers

[dsasser]

Mid Sprint Update 10-10-24

QA took a pause while we moved all the CMS work behind a feature toggle to allow for a smoother deployment in conjunction with the content-build changes. That work is in PR pending review. Once merged, it will trigger the (hopefully) final round of QA for the CMS side of things represented in this issue.

[davidmpickett]

I answered my question about what happens if there's a Draft Latest Revision with a change to the phone number before we run the migration. The migration uses the phone number from the Current Revision. This makes sense that we would give higher priority to the published content than draft content. There is also no data loss since the previous revision is still available in Drupal

[davidmpickett]

End of sprint update:
I'm honestly not sure what Drupal-specific QA is left after @dsasser's refactor of the code to place the phone number changes behind a feature toggle. We've verified:

• The migration works as intended
  • AND we cleaned up a bunch of data that wasn't parsed by the migration
    • AND AND because the output of the migration is now safely behind a toggle, we could run the migration on prod and doadditional manual cleanup without impacting anything for editors or veterans
• The UI changes are safely behind a toggle
  • AND The UI changes are all correct
    • AND AND because the changes the behind a toggle, we could almost instantaneously revert changes on prod

There will need to be additional QA of the FE output once those tickets are complete pending integration, but that's different from this ticket.

@omahane @Agile6MSkinner @jilladams @dsasser let's discuss in 16th minute tomorrow

[dsasser]

End of sprint update: I'm honestly not sure what Drupal-specific QA is left after @dsasser's refactor of the code to place the phone number changes behind a feature toggle.

As we discussed in scrum, there is no further QA that needs to happen, and we are free to move the integration PR into a mergable state, which requires code review from Facilities/PW, Platform CMS, and Platform CMS Devops (usually Platform CMS utilizes one person to fulfill both user groups. I'm getting the PR in shape for final review (removing DO NOT MERGE label, other cleanup) by our team first, and then Platform CMS once we have approvals on our end.

[jilladams]

This ticket is our acting artifact for getting the code merged, so: I'm gonna move it to Prod Verification just so we remember to double check things in prod after the PR merges and make sure the toggle is doing what we expect.

[jilladams]

You know what, no. QA is done, and we're gonna merge. THe actual original phone number tix are in COmplete Pending Integration, and those will track moving through to Prod verification > Done. Closing this.