VACMS-17854: Add feature toggle to display old/new telephone fields conditionally

[dsasser]

Description

Moves the new telephone migration fields behind a feature toggle.

Relates to #17854

Testing done

Manual

QA steps (happy path, full QA happens here)

Run the migration (daily, once; check the telephone audit View and/or the Codit Batch Operations logs to see if the migration has been run by someone else before running)

Get a terminal in the tugboat
Run the following commands:

time drush codit-batch-operations:run MigratePhoneFieldToParagraph &&
time drush codit-batch-operations:run MigrateVamcBillingInsurancePhoneFieldToParagraph &&
time drush codit-batch-operations:run MigrateVamcFacilityMentalHealthPhoneFieldToParagraph 

Validate Old Fields Appear on Node New with Toggle Off:

• Visit the Flipper Toggle admin page and ensure the FEATURE_TELEPHONE_MIGRATION_V1 toggle is not checked.
• View a VAMC System Billing and Insurance node in a new tab (you will return to this tab later)
• Confirm the old phone number is visible
• Confirm the new phone number is not visible
• View a Staff Profile in new tab (you will return to this tab later)
• Confirm the old phone number is visible
• Confirm the new phone number is not visible
• View a VAMC Facility in a new tab (you will return to this tab later)
• Confirm the Mental health old phone number is visible
• Confirm the new phone number is not visible

Validate Old Fields Appear on Node Edit with Toggle Off:

• Visit the Flipper Toggle admin page and ensure the FEATURE_TELEPHONE_MIGRATION_V1 toggle is not checked.
• Edit a VAMC System Billing and Insurance node in a new tab (you will return to this tab later)
• Confirm the old phone number is visible
• Confirm the new phone number is not visible
• Edit a Staff Profile in new tab (you will return to this tab later)
• Confirm the old phone number is visible
• Confirm the new phone number is not visible
• Edit a VAMC Facility in a new tab (you will return to this tab later)
• Confirm the old Mental health phone number is visible
• Confirm the new phone number is not visible

Validate Old Fields appear on Node Add Forms with Toggle Off:

• Visit the create VAMC System Billing and Insurance node page in a new tab (you will return to this tab later)
• Confirm the old phone number is visible
• Confirm the new phone number is not visible
• Visit the create Staff Profile node page in a new tab (you will return to this tab later)
• Confirm the old phone number is visible
• Confirm the new phone number is not visible
• Visit the create VAMC Facility node page in a new tab (you will return to this tab later)
• Confirm the old Mental health phone number is visible
• Confirm the new phone number is not visible

Validate New Fields Appear on Node View With Toggle On

• Visit the Flipper Toggle admin page and check the FEATURE_TELEPHONE_MIGRATION_V1 checkbox and save the form.
• Clear the cache
• View the VAMC System Billing and Insurance node
• Confirm the new phone number is visible
• Confirm the old phone number not visible
• View the Staff Profile
• Confirm the new phone number is visible
• Confirm the old phone number not visible
• View a VAMC Facility
• Confirm the new Mental health phone number is visible
• Confirm the old phone number not visible

Validate New Fields Appear on Node Edit With Toggle On

• Visit the Flipper Toggle admin page and check the FEATURE_TELEPHONE_MIGRATION_V1 checkbox and save the form.
• Return to the VAMC System Billing and Insurance node
• Confirm the new phone number is visible
• Confirm the old phone number not visible
• Return to the Staff Profile in new tab
• Confirm the new phone number is visible
• Confirm the old phone number not visible
• Return to the VAMC Facility
• Confirm the new Mental health phone number is visible
• Confirm the old Mental health phone number not visible

Validate New Fields appear on Node Add Forms with Toggle On:

• Visit the create VAMC System Billing and Insurance node page in a new tab (you will return to this tab later)
• Confirm the old phone number is visible
• Confirm the new phone number is not visible
• Visit the create Staff Profile node page in a new tab (you will return to this tab later)
• Confirm the old phone number is visible
• Confirm the new phone number is not visible
• Visit the create VAMC Facility node page in a new tab (you will return to this tab later)
• Confirm the old Mental health phone number is visible
• Confirm the new phone number is not visible

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[omahane]

Post-migration (toggle off)

As soon as I went to look at the node on the node:view (as opposed to node:edit), I noticed that the new field is showing even with the toggle off.

I believe that we would expect to find the old field showing on both the view and edit screens.

Pre-migration (toggle off)

[omahane]

Node:edit (Toggle on), as content admin

I refactored the form display a bit to account for the fact that we have 2 phone fields on the VAMC facility, as I saw that we ended up hiding the facility phone number on the form for content admins (and above) unintentionally:

[omahane]

We should check

• node:view for all three content types
• admins
• non-admins

[omahane]

Found a change needed on node:add for VAMC Facility:

• both the old and new fields are showing