Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17854: Add feature toggle to display old/new telephone fields conditionally #19472

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d881657
VACMS-17854: Adds telephone migration audit View.
dsasser Oct 9, 2024
29074ba
VACMS-17854: Adds feature toggle for telephone migration.
dsasser Oct 9, 2024
6af1b2e
VACMS-17854: Show both telephone fields on Staff Profile content type…
dsasser Oct 9, 2024
8376953
VACMS-17854: Show both telephone fields on VAMC Facility Billing and …
dsasser Oct 9, 2024
d34f1d2
VACMS-17854: Show both telephone fields on VAMC Facility content type…
dsasser Oct 9, 2024
89d9f9b
VACMS-17854: Put telephone fields behind feature toggle for Staff Pro…
dsasser Oct 9, 2024
2aac8ad
VACMS-17854: Leverage feature toggle to return correct phone for a VA…
dsasser Oct 9, 2024
bf39b62
VACMS-17854: Put telephone field behind feature toggle for VAMC Syste…
dsasser Oct 9, 2024
17279aa
VACMS-17854: Remove test validations introduced in ealier commits. Th…
dsasser Oct 9, 2024
39cd44f
Merge branch 'VACMS-17854-integration-phone-number-migrations' into V…
dsasser Oct 10, 2024
3d1baf7
VACMS-18163: Adds new 'How to Apply' field to Benefits taxonomy (#19445)
jv-agile6 Oct 10, 2024
7060de0
Bump va-gov/content-build from 0.0.3611 to 0.0.3612 (#19487)
dependabot[bot] Oct 11, 2024
47970ee
VACMS-17854: Adds changes to composer
omahane Oct 11, 2024
de6819d
VACMS-17854: Adds node:view to toggle and accounts for two facility p…
omahane Oct 11, 2024
ab03b19
VACMS-17854: Updates config so code can hide fields
omahane Oct 11, 2024
0128acd
VACMS-17854: Adds check for new facility form
omahane Oct 14, 2024
6db1309
VACMS-17854: Updates the logic for computers, instead of humans
omahane Oct 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@
"symfony/phpunit-bridge": "^5.1",
"symfony/process": "^6.3",
"symfony/routing": "^6.3",
"va-gov/content-build": "^0.0.3611",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated version of content-build

"va-gov/content-build": "^0.0.3612",
"vlucas/phpdotenv": "^5.6",
"webflo/drupal-finder": "1.2.2",
"webmozart/path-util": "^2.3",
Expand Down
22 changes: 11 additions & 11 deletions composer.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
"This file is @generated automatically"
],
"content-hash": "d611d7b804b8f2f4f8ea07a4a3a3cd55",
"content-hash": "09f17de1694170b346fd43b8b022d5bf",
"packages": [
{
"name": "asm89/stack-cors",
Expand Down Expand Up @@ -26644,16 +26644,16 @@
},
{
"name": "va-gov/content-build",
"version": "v0.0.3611",
"version": "v0.0.3612",
"source": {
"type": "git",
"url": "https://github.com/department-of-veterans-affairs/content-build.git",
"reference": "f44a4ade749e41ae1d98afd735e29ea7fcf619d4"
"reference": "895da1620d56d11772955b6aa2d872810a16771f"
},
"dist": {
"type": "zip",
"url": "https://api.github.com/repos/department-of-veterans-affairs/content-build/zipball/f44a4ade749e41ae1d98afd735e29ea7fcf619d4",
"reference": "f44a4ade749e41ae1d98afd735e29ea7fcf619d4",
"url": "https://api.github.com/repos/department-of-veterans-affairs/content-build/zipball/895da1620d56d11772955b6aa2d872810a16771f",
"reference": "895da1620d56d11772955b6aa2d872810a16771f",
"shasum": ""
},
"type": "node-project",
Expand All @@ -26680,9 +26680,9 @@
"description": "Front-end for VA.gov. This repository contains the code that generates the www.va.gov website. It contains a Metalsmith static site builder that uses a Drupal CMS for content. This file is here to publish releases to https://packagist.org/packages/va-gov/content-build, so that the CMS CI system can install it and update it using standard composer processes, and so that we can run tests across both systems. See https://github.com/department-of-veterans-affairs/va.gov-cms for the CMS repo, and stand by for more documentation.",
"support": {
"issues": "https://github.com/department-of-veterans-affairs/content-build/issues",
"source": "https://github.com/department-of-veterans-affairs/content-build/tree/v0.0.3611"
"source": "https://github.com/department-of-veterans-affairs/content-build/tree/v0.0.3612"
},
"time": "2024-10-07T22:27:44+00:00"
"time": "2024-10-09T21:01:11+00:00"
},
{
"name": "vlucas/phpdotenv",
Expand Down Expand Up @@ -27673,6 +27673,7 @@
"drupal/fieldhelptext": 10,
"drupal/flag": 10,
"drupal/graphql_menu": 15,
"drupal/html_tag_usage": 10,
"drupal/image_style_warmer": 5,
"drupal/jsonapi_resources": 10,
"drupal/limited_field_widgets": 15,
Expand All @@ -27692,13 +27693,12 @@
"drupal/simplesamlphp_auth": 5,
"drupal/styleguide": 10,
"drupal/user_history": 15,
"drupal/viewfield": 10,
"drupal/html_tag_usage": 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed viewfield

"drupal/viewfield": 10
},
"prefer-stable": true,
"prefer-lowest": false,
"platform": [],
"platform-dev": [],
"platform": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed from arrays to objects

"platform-dev": {},
"platform-overrides": {
"php": "8.1"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ third_party_settings:
label: 'Section settings'
region: content
parent_name: ''
weight: 9
weight: 10
format_type: details_sidebar
format_settings:
classes: ''
Expand All @@ -66,7 +66,7 @@ third_party_settings:
label: 'Editorial Workflow'
region: content
parent_name: ''
weight: 10
weight: 11
format_type: fieldset
format_settings:
classes: ''
Expand All @@ -79,7 +79,7 @@ third_party_settings:
label: '"Prepare for your visit"'
region: content
parent_name: ''
weight: 7
weight: 8
format_type: details
format_settings:
classes: ''
Expand All @@ -94,7 +94,7 @@ third_party_settings:
label: 'VAMC system'
region: content
parent_name: ''
weight: 3
weight: 4
format_type: fieldset
format_settings:
classes: ''
Expand All @@ -108,7 +108,7 @@ third_party_settings:
label: 'Title and summary'
region: content
parent_name: ''
weight: 4
weight: 5
format_type: fieldset
format_settings:
classes: ''
Expand All @@ -120,7 +120,7 @@ third_party_settings:
label: 'Social Media'
region: content
parent_name: ''
weight: 6
weight: 7
format_type: fieldset
format_settings:
classes: ''
Expand All @@ -134,7 +134,7 @@ third_party_settings:
label: 'Operating status'
region: content
parent_name: ''
weight: 2
weight: 3
format_type: fieldset
format_settings:
classes: ''
Expand All @@ -149,7 +149,7 @@ third_party_settings:
label: 'Meta Tags'
region: content
parent_name: ''
weight: 5
weight: 6
format_type: fieldset
format_settings:
classes: ''
Expand All @@ -159,6 +159,7 @@ third_party_settings:
group_locations_and_contact_info:
children:
- group_facility_data_from_vast
- field_mental_health_phone
label: 'Locations and contact information'
region: content
parent_name: ''
Expand Down Expand Up @@ -232,7 +233,7 @@ content:
third_party_settings: { }
field_administration:
type: options_select
weight: 13
weight: 14
region: content
settings: { }
third_party_settings: { }
Expand Down Expand Up @@ -288,7 +289,7 @@ content:
third_party_settings: { }
field_last_saved_by_an_editor:
type: datetime_timestamp
weight: 11
weight: 12
region: content
settings: { }
third_party_settings: { }
Expand All @@ -306,7 +307,7 @@ content:
third_party_settings: { }
field_main_location:
type: boolean_checkbox
weight: 21
weight: 22
region: content
settings:
display_label: true
Expand All @@ -318,6 +319,13 @@ content:
settings:
media_types: { }
third_party_settings: { }
field_mental_health_phone:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added field_mental_health_phone

type: telephone_default
weight: 21
region: content
settings:
placeholder: ''
third_party_settings: { }
field_mobile:
type: boolean_checkbox
weight: 26
Expand Down Expand Up @@ -410,7 +418,7 @@ content:
third_party_settings: { }
path:
type: path
weight: 8
weight: 9
region: content
settings: { }
third_party_settings: { }
Expand All @@ -432,7 +440,6 @@ content:
hidden:
created: true
field_local_health_care_service_: true
field_mental_health_phone: true
field_meta_tags: true
field_supplemental_status: true
field_supplemental_status_more_i: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ dependencies:
- node.type.health_care_local_facility
module:
- field_group
- ief_table_view_mode
- telephone
- textfield_counter
third_party_settings:
field_group:
Expand All @@ -40,7 +42,7 @@ third_party_settings:
label: 'Section settings'
region: hidden
parent_name: ''
weight: 25
weight: 31
format_type: details_sidebar
format_settings:
classes: ''
Expand All @@ -50,13 +52,13 @@ third_party_settings:
weight: -10
group_editorial_workflow:
children:
- revision_log
- moderation_state
- revision_log
- flag
label: 'Editorial Workflow'
region: hidden
parent_name: ''
weight: 27
weight: 32
format_type: fieldset
format_settings:
classes: ''
Expand All @@ -69,7 +71,7 @@ third_party_settings:
label: 'Facility Locator'
region: hidden
parent_name: ''
weight: 23
weight: 29
format_type: fieldset
format_settings:
classes: ''
Expand All @@ -83,7 +85,7 @@ third_party_settings:
label: 'Location services'
region: hidden
parent_name: ''
weight: 24
weight: 30
format_type: details
format_settings:
classes: ''
Expand All @@ -98,7 +100,7 @@ third_party_settings:
label: Region
region: hidden
parent_name: ''
weight: 22
weight: 28
format_type: fieldset
format_settings:
classes: ''
Expand All @@ -110,6 +112,13 @@ targetEntityType: node
bundle: health_care_local_facility
mode: inline_entity_form
content:
field_mental_health_phone:
type: telephone_default
weight: 22
region: content
settings:
placeholder: ''
third_party_settings: { }
field_operating_status_facility:
type: options_select
weight: 1
Expand All @@ -126,9 +135,29 @@ content:
maxlength: 300
counter_position: after
js_prevent_submit: true
count_only_mode: false
count_html_characters: true
textcount_status_message: '<span class="remaining_count">@remaining_count</span> characters remaining'
third_party_settings: { }
field_telephone:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added field_telephone:

type: inline_entity_form_complex_table_view_mode
weight: 3
region: content
settings:
form_mode: default
override_labels: false
label_singular: ''
label_plural: ''
allow_new: true
allow_existing: false
match_operator: CONTAINS
allow_duplicate: false
collapsible: false
collapsed: false
revision: false
removed_reference: optional
allow_system_delete: false
third_party_settings: { }
title:
type: string_textfield
weight: 0
Expand All @@ -151,15 +180,13 @@ hidden:
field_location_services: true
field_main_location: true
field_media: true
field_mental_health_phone: true
field_meta_tags: true
field_mobile: true
field_office_hours: true
field_phone_number: true
field_region_page: true
field_supplemental_status: true
field_supplemental_status_more_i: true
field_telephone: true
field_timezone: true
flag: true
langcode: true
Expand Down
Loading
Loading