VACMS-18281 Added character counters & help text to phone paragraph type

[davidmpickett]

Description

Relates to #18281 & #15803

Testing done

Using the entity relationship diagram, I identified 4 different Drupal entities that currently use the Phone Paragraph type

• VAMC System VA police Page -> Tested directly
• Service Location paragraph -> Tested via VAMC Facility Health Service
• Contact Information paragraph -> Tested via Resources and Support Detail Page
• VAMC Facility Health Service node -> (A legacy field which is hidden in the UI, but hasn't been deleted yet)

Screenshots

Character counts updates without help text changes

Help Text changes without character count update

All together now

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

1. Log in to tugboat as an Admin (e.g. [email protected])
2. Add a new VAMC Facility Health Service
   • Under Service Location go to Appointments > Phone number for appointments > Add a phone number
   • Under Service Location go to Contact Info > Phone > Add a phone number
   • Validate that character counters behave as expected
   • Validate that help text shows up as expected
3. Add a new VAMC System VA police Page
   • Under Contact phone number
   • Validate that character counters behave as expected
   • Validate that help text shows up as expected
4. Add a new Resources & and Support detail page
   • Under Contact information > Add a phone number
   • Validate that character counters behave as expected
   • Validate that help text shows up as expected

Definition of Done

• Automated tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[davidmpickett]

Updated so this will close two related issues instead of just 1

[thejordanwood]

Looks great!

[laflannery]

The help text does not appear to match what's in Figma:

[davidmpickett]

The help text does not appear to match what's in Figma:

Gah, I was bamboozled by a comment preview

Foolishly, I took it at it's word and did not dive deeper

I'll go fix that now

[thejordanwood]

@laflannery You have the eagle eyes today, because apparently I'm blind as a bat.

@davidmpickett I've re-reviewed the new tugboat and can confirm that the phone number field now says "Use the format 123-456-7890." I also want to call out that the label field says "Enter what office..." instead of "Indicate what office..." like in the Figma file, but I actually prefer to use the word "enter" here.

[laflannery]

If Jordan approves the change that works for me!

[omahane]

Everything checks out and looks good. Nice work.