Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAGOV-TEAM-87958: Integration branch for Form Engine POC #18811

Merged
merged 9 commits into from
Sep 20, 2024
Merged

VAGOV-TEAM-87958: Integration branch for Form Engine POC #18811

merged 9 commits into from
Sep 20, 2024

Conversation

ryguyk
Copy link
Contributor

@ryguyk ryguyk commented Jul 31, 2024 •
edited
Loading

Description

This is a PR for an integration branch that has individual PRs merged into it as listed below.

Relates to department-of-veterans-affairs/va.gov-team#87958

Individual PRs incorporated:

Testing done

Unit tests added on individual PRs. Manual smoke tests to confirm new content type is working and existing content types aren't affected.

Screenshots

QA steps

  • Navigate to node-create form for Digital Form and ensure form loads.
    • Complete form
    • Ensure revision-log input is visible and add revision message
    • Save form and ensure form saves properly
    • Edit node and ensure it saves properly again.
  • Navigate to some other node-create forms and ensure they render/save as expected

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@ryguyk ryguyk requested review from a team as code owners July 31, 2024 17:38
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 31, 2024 17:38 Destroyed
@ryguyk ryguyk changed the title VAGOV-TEAM-87958: Integration branch for Form Engine POC DNM: VAGOV-TEAM-87958: Integration branch for Form Engine POC Jul 31, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 31, 2024 22:00 Destroyed
@ryguyk ryguyk requested a review from a team as a code owner August 26, 2024 15:55
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 26, 2024 15:55 Destroyed
@ryguyk ryguyk force-pushed the VAGOV-TEAM-87958-integration-form-engine-poc branch from cd67b22 to 5c55049 Compare August 26, 2024 16:26
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 26, 2024 16:27 Destroyed
timcosgrove
timcosgrove approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@timcosgrove timcosgrove left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, if you decide to move ahead, and pending Cypress tests passing.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 27, 2024 23:34 Destroyed
@ryguyk ryguyk changed the title DNM: VAGOV-TEAM-87958: Integration branch for Form Engine POC VAGOV-TEAM-87958: Integration branch for Form Engine POC Sep 3, 2024
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Sep 3, 2024
@ryguyk ryguyk force-pushed the VAGOV-TEAM-87958-integration-form-engine-poc branch from 5c55049 to af73e95 Compare September 3, 2024 18:10
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 3, 2024 18:10 Destroyed
@ryguyk
Copy link
Contributor Author

ryguyk commented Sep 3, 2024

@timcosgrove I've rebased onto main and Cypress tests are now passing. I think this is good to go now. It looks like we might need re-approval.

@ryguyk ryguyk force-pushed the VAGOV-TEAM-87958-integration-form-engine-poc branch from af73e95 to 2c479a4 Compare September 4, 2024 13:53
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 4, 2024 13:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 13, 2024 20:02 Destroyed
@ryguyk ryguyk force-pushed the VAGOV-TEAM-87958-integration-form-engine-poc branch from 2c479a4 to b7d7f37 Compare September 16, 2024 16:13
derekhouck and others added 4 commits September 17, 2024 09:27
@derekhouck @ryguyk
VATEAM-87711: Add Digital Form content type (#18717)
9316c27 
* Add Digital Form content type

* Update Digital Form description

---------

Co-authored-by: Derek Houck <[email protected]>
@derekhouck @ryguyk
Add chapters field to Digital Form
c4c5031
@derekhouck @ryguyk
Add screenshot of name and dob pattern
0d280ef
@derekhouck @ryguyk
VATEAM-88658: Script to add Digital Forms test data (#19025)
a58e4e1 
* WIP: Create digital form script

* Add steps

* Rename exit_if_wrong_env
@ryguyk ryguyk force-pushed the VAGOV-TEAM-87958-integration-form-engine-poc branch from b7d7f37 to a58e4e1 Compare September 17, 2024 14:27
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 08:27 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 19:05 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 19, 2024 08:29 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 19, 2024 22:20 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 20, 2024 08:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 20, 2024 15:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 20, 2024 16:41 Destroyed
srancour
srancour approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@srancour srancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with understanding that this was not ready for accessibility testing.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 20, 2024 18:01 Destroyed
@ryguyk ryguyk merged commit 6abe545 into main Sep 20, 2024
18 checks passed
@ryguyk ryguyk deleted the VAGOV-TEAM-87958-integration-form-engine-poc branch September 20, 2024 18:39
keisterj-oddball pushed a commit that referenced this pull request Sep 20, 2024
@ryguyk @derekhouck
@timcosgrove @keisterj-oddball
VAGOV-TEAM-87958: Integration branch for Form Engine POC (#18811)
cf8758f 
* VATEAM-87711: Add Digital Form content type (#18717)

* Add Digital Form content type

* Update Digital Form description

---------

Co-authored-by: Derek Houck <[email protected]>

* Add chapters field to Digital Form

* Add screenshot of name and dob pattern

* VATEAM-88658: Script to add Digital Forms test data (#19025)

* WIP: Create digital form script

* Add steps

* Rename exit_if_wrong_env

---------

Co-authored-by: Derek Houck <[email protected]>
Co-authored-by: Derek Houck <[email protected]>
Co-authored-by: Derek Houck <[email protected]>
Co-authored-by: Tim Cosgrove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srancour srancour srancour approved these changes

@timcosgrove timcosgrove timcosgrove approved these changes

Assignees
No one assigned
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryguyk @timcosgrove @srancour @va-cms-bot @derekhouck