Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-17854: Fix phpstan warnings. #19362

Merged
merged 2 commits into from
Oct 1, 2024
Merged

VACMS-17854: Fix phpstan warnings. #19362

merged 2 commits into from
Oct 1, 2024

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Oct 1, 2024 •
edited by omahane
Loading

Description

Fixes phpstan/reviewdog warnings.

Relates to #17854

Testing done

Automated

QA steps

  • Automated tests and checks pass

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@dsasser dsasser requested a review from a team as a code owner October 1, 2024 05:28
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 05:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 13:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 14:16 Destroyed
@omahane omahane requested a review from a team as a code owner October 1, 2024 16:05
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 16:06 Destroyed
omahane
omahane approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up checking all the changed content types, which is how I found the change I needed to make. I tested a couple of the migrations, and they worked. All tests have thus far passed, too.

@dsasser dsasser merged commit 3034b6a into VACMS-17854-integration-phone-number-migrations Oct 1, 2024
17 checks passed
@dsasser dsasser deleted the VACMS-17854-phpstan-reviewdog-fixes branch October 1, 2024 17:20
@omahane omahane restored the VACMS-17854-phpstan-reviewdog-fixes branch October 3, 2024 20:36
dsasser added a commit that referenced this pull request Oct 16, 2024
@dsasser @omahane
@jv-agile6 @dependabot
VACMS-17860: Telephone Migrations Integration (#19225)
7515305 
* VACMS-17860: Updates staff phone field to paragraph field (#19038)

* VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type.

* VACMS-17860: Adds codit_batch_operations to codebase.

* VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS.

* VACMS-17860: Replaces bespoke batch operation with a BatchOperations class.

* VACMS-17860: Adds new telephone paragraph field to staff profile.

* VACMS-17860: Fixes the phone validation and parsing.

* VACMS-17860: Avoids unefined array index warnings.

* VACMS-17860: Removes unused method

* VACMS-17860: Remove batching configuration in our class because it is already setup in codit.

* VACMS-17860: Ensures old phone is not shown on edit form.

* VACMS-17860: Fixes extension migration.

* VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile.

* VACMS-17860: Restores revision log on staff profile form.

* VACMS-17860: Updates cypress test.

* VACMS-17860: Fixes typo in CODEOWNERS.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Fixes selector in cypress test.

* VACMS-17861: Minor updates to deploy script.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload.

* VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error.

* VACMS-17860: Updates nginx config to align with latest ddev default config for D10.

* VACMS-17854: Updates composer.lock

* VACMS-17862: Moves VACMS facility Mental health phone number from field to paragraph (#19234)

* VACMS-17862: Adds configuration changes and script to migrating phones

* VACMS-17862: Updates the phone number audit view

* VACMS-17862: Adds data push changes for mental health

* VACMS-17862: Updates the mental health data push code.

* VACMS-17862: Accounts for no mental health paragraph

* VACMS-17862: Update node and view config

* VACMS-17862: Restores revision_log

* VACMS-17862: Adds step for filling mental health phone

* VACMS-17862: Adds deploy hook and data bypass

* VACMS-17862: Fixes path to script-library

* VACMS-17862: Add help text

* VACMS-17854: Updates composer.lock

* Revert "VACMS-17854: Updates composer.lock"

This reverts commit 4bb3c93.

* Updates the deploy, removing the new one

* VACMS-17860: Removes deploy script for Staff Profile telephone migration (#19308)

* VACMS-17860: Removes deploy hook for Staff Profile telephone field migration in order to manually perform the migration via drush using codit's drush command.

---------

Co-authored-by: Christian Burk <[email protected]>

* VACMS-17861: Replace VAMC Billing and Insurance telephone field with telephone paragraph (#19264)

* VACMS-17860: Updates staff phone field to paragraph field (#19038)

* VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type.

* VACMS-17860: Adds codit_batch_operations to codebase.

* VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS.

* VACMS-17860: Replaces bespoke batch operation with a BatchOperations class.

* VACMS-17860: Adds new telephone paragraph field to staff profile.

* VACMS-17860: Fixes the phone validation and parsing.

* VACMS-17860: Avoids unefined array index warnings.

* VACMS-17860: Removes unused method

* VACMS-17860: Remove batching configuration in our class because it is already setup in codit.

* VACMS-17860: Ensures old phone is not shown on edit form.

* VACMS-17860: Fixes extension migration.

* VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile.

* VACMS-17860: Restores revision log on staff profile form.

* VACMS-17860: Updates cypress test.

* VACMS-17860: Fixes typo in CODEOWNERS.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Fixes selector in cypress test.

* VACMS-17861: Minor updates to deploy script.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload.

* VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error.

* VACMS-17860: Updates nginx config to align with latest ddev default config for D10.

* VACMS-17854: Updates content-hash

* VACMS-17861: Adds telephone field to VAMC Billing and Insurance content type.
- Adds migration to move from old field to new paragraph.

* VACMS-17861: Removed unwanted deploy hook.

* VACMS-17861: Fixing branch rebase issues

* VACMS-17861: Ensures old phone number is no longer displayed.

* VACMS-17861: Hides phone label using existing method.

* VACMS-17861: Resores missing revision_log.

---------

Co-authored-by: Christian Burk <[email protected]>
Co-authored-by: Jerry Vrabel <[email protected]>

* VACMS-17854: Fix phpstan warnings.

* VACMS-17854: Updates function calls with correct type

* VACMS-17854: Fix phpstan warnings. (#19362)

* VACMS-17854: Fix phpstan warnings.

* VACMS-17854: Updates function calls with correct type

---------

Co-authored-by: Christian Burk <[email protected]>

* VACMS-17854: Merges main and updates composer lock

* VACMS-17854: Add feature toggle to display old/new telephone fields conditionally (#19472)

* VACMS-17854: Adds telephone migration audit View.

* VACMS-17854: Adds feature toggle for telephone migration.

* VACMS-17854: Show both telephone fields on Staff Profile content type form.

* VACMS-17854: Show both telephone fields on VAMC Facility Billing and Insurance content type form

* VACMS-17854: Show both telephone fields on VAMC Facility content type form.

* VACMS-17854: Put telephone fields behind feature toggle for Staff Profile content type.

* VACMS-17854: Leverage feature toggle to return correct phone for a VAMC Facility in posts into Lighthouse.

* VACMS-17854: Put telephone field behind feature toggle for VAMC System Billing and Insurand and VAMC Facility content types.

* VACMS-17854: Remove test validations introduced in ealier commits. These can be added back after the telephone migration is complete.

* VACMS-18163: Adds new 'How to Apply' field to Benefits taxonomy (#19445)

* VACMS-18163: BenefitTaxonomy four configs for how to apply

* VACMS-18163: Added- revision_log_message to group_va_benefit_workflow

* VACMS-18163: changes to config for field translation

* VACMS-18163: Manual addition of - revision_log_message

* Bump va-gov/content-build from 0.0.3611 to 0.0.3612 (#19487)

Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3611 to 0.0.3612.
- [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases)
- [Commits](department-of-veterans-affairs/content-build@v0.0.3611...v0.0.3612)

---
updated-dependencies:
- dependency-name: va-gov/content-build
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* VACMS-17854: Adds node:view to toggle and accounts for two facility phone fields

* VACMS-17854: Updates config so code can hide fields

* VACMS-17854: Adds check for new facility form

* VACMS-17854: Updates the logic for computers, instead of humans

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: jv-agile6 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christian Burk <[email protected]>

* VACMS-17854: Fix composer.lock merge conflict resolution mistake by updating content-build to the latest release to match main.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Christian Burk <[email protected]>
Co-authored-by: Jerry Vrabel <[email protected]>
Co-authored-by: jv-agile6 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omahane omahane omahane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsasser @omahane @va-cms-bot