Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19163: changed required astrisk to after #19882

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jv-agile6
Copy link
Contributor

@jv-agile6 jv-agile6 commented Nov 15, 2024

Description

Relates to #19163

QA steps

name: "Campaign Landing Page - Spotlight Validation"

description: QA test for ensuring required fields and validation indicators appear correctly when editing a Campaign Landing Page, and that error messages are properly linked to the corresponding fields.

steps:

  • step: "Go to Tugboat instance Log in and create a new Campaign Landing Page."
    expected_result: "Login and successfully go to create a Campaign Landing Page"

    Screenshot 2024-11-19 at 12 07 52 PM
  • step: "Fill out the required fields in the Hero Banner, Why This Matters, What You Can Do, VA Benefits sections. and Selection settings"
    expected_result: "Required fields are filled out without issues."

Screenshot 2024-11-19 at 12 22 39 PM
  • step: "Save as Published and save the node."
    expected_result: "Node is saved successfully."
Screenshot 2024-11-19 at 12 24 51 PM
  • step: "Edit the node and enable the Spotlight section by clicking 'Enable this page segment.'"
    expected_result: "Spotlight section is enabled."
Screenshot 2024-11-20 at 3 13 15 PM
  • step: "Check if the 'List of links with summaries' field is marked as required (red asterisk)."
    expected_result: "The 'List of links with summaries' field is marked with a red asterisk."
Screenshot 2024-11-22 at 12 52 50 PM
  • step: "Add a Link teaser to the 'Links with summaries' field."
    expected_result: "Link teaser is added successfully."
Screenshot 2024-11-20 at 3 16 22 PM
  • step: "Save the node again."
    expected_result: "Node is saved successfully without errors."
Screenshot 2024-11-20 at 3 18 27 PM

expected_behavior:

  • "Required field 'List of links with summaries' should have a red asterisk."

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 15, 2024 15:25 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 15, 2024 15:31 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 16, 2024 09:16 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 17, 2024 09:05 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 18, 2024 09:06 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 18, 2024 16:32 Destroyed
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 19, 2024 08:59 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 19, 2024 15:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 19, 2024 17:06 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 20, 2024 08:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 20, 2024 20:38 Destroyed
Copy link

Checking composer.lock changes...

@jv-agile6 jv-agile6 marked this pull request as ready for review November 20, 2024 21:22
@jv-agile6 jv-agile6 requested review from a team as code owners November 20, 2024 21:22
Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, but also seeing duplicate required indicators on the link field:

Screenshot 2024-11-20 at 2 19 16 PM

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 21, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 21, 2024 14:54 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 25, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 26, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 27, 2024 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 28, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 29, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 30, 2024 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 31, 2024 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 1, 2025 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2025 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 4, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 5, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 6, 2025 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 7, 2025 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 8, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 10, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 12, 2025 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 13, 2025 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 14, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 15, 2025 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 16, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 17, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 18, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 19, 2025 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 20, 2025 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 21, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 22, 2025 08:34 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants