-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-19163: changed required astrisk to after #19882
Open
jv-agile6
wants to merge
8
commits into
main
Choose a base branch
from
VACMS-19163-LinksfieldSpotlightCLPrequired
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking composer.lock changes... |
Checking composer.lock changes... |
GitHub Workflows (.github/workflows/*.yml)Have you...
|
Checking composer.lock changes... |
…dSpotlightCLPrequired
Checking composer.lock changes... |
Checking composer.lock changes... |
dsasser
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docroot/themes/custom/vagovclaro/assets/scss/components/_paragraphs.scss
Outdated
Show resolved
Hide resolved
docroot/themes/custom/vagovclaro/assets/scss/components/_paragraphs.scss
Outdated
Show resolved
Hide resolved
docroot/themes/custom/vagovclaro/assets/scss/components/_paragraphs.scss
Outdated
Show resolved
Hide resolved
Checking composer.lock changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #19163
QA steps
name: "Campaign Landing Page - Spotlight Validation"
description: QA test for ensuring required fields and validation indicators appear correctly when editing a Campaign Landing Page, and that error messages are properly linked to the corresponding fields.
steps:
step: "Go to Tugboat instance Log in and create a new Campaign Landing Page."
expected_result: "Login and successfully go to create a Campaign Landing Page"
step: "Fill out the required fields in the Hero Banner, Why This Matters, What You Can Do, VA Benefits sections. and Selection settings"
expected_result: "Required fields are filled out without issues."
expected_result: "Node is saved successfully."
expected_result: "Spotlight section is enabled."
expected_result: "The 'List of links with summaries' field is marked with a red asterisk."
expected_result: "Link teaser is added successfully."
expected_result: "Node is saved successfully without errors."
expected_behavior:
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?