Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump flipper gems to 1.2.2 #15541

Merged
merged 3 commits into from
Feb 21, 2024
Merged

bump flipper gems to 1.2.2 #15541

merged 3 commits into from
Feb 21, 2024

Conversation

stevenjcumming
Copy link
Contributor

@stevenjcumming stevenjcumming commented Feb 14, 2024

Summary

  • Upgrade flipper to v1.2.2
  • Upgrade flipper-active_record to v1.2.2
  • Upgrade flipper-active_support_cache_store to v1.2.2
  • Upgrade flipper-ui to v1.2.2
  • Flipper 1.2 introduced TestHelper which caused some issues because all features are disable by default.
    • more info: Flipper PR & Docs
    • It was disable in config/initializers/flipper.rb
  • Flipper 1.2 required a migration to change the column type on flipper_gates and add indexes to flipper_features and flipper_gates

Related issue(s)

Testing done

  • No new test added
  • Existing test suite passed

Acceptance criteria

  • All above gems are v1.2.2 in Gemfile.lock

Copy link

github-actions bot commented Feb 14, 2024

1 Error
🚫

Modified files in db/ should be the only files checked into this PR.

File Summary

DB File(s)

  • db/migrate/20240214185628_change_flipper_gates_value_to_text.rb

  • db/migrate/20240214215514_add_flipper_indexes.rb

  • db/schema.rb

    App File(s)

    • Gemfile.lock
  • config/initializers/flipper.rb

Database migrations do not run automatically with vets-api deployments. Application code must always be
backwards compatible with the DB, both before and after migrations have been run. For more info:

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-flipper-1.2.2/main/main February 14, 2024 22:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-flipper-1.2.2/main/main February 14, 2024 22:13 Inactive
@stevenjcumming
Copy link
Contributor Author

1 Error
🚫
Modified files in db/ should be the only files checked into this PR.

File Summary
Database migrations do not run automatically with vets-api deployments. Application code must always be backwards compatible with the DB, both before and after migrations have been run. For more info:

Generated by 🚫 Danger

The link for Deployment Process is not found (404)

@stevenjcumming stevenjcumming marked this pull request as ready for review February 21, 2024 15:33
@stevenjcumming stevenjcumming requested review from a team as code owners February 21, 2024 15:33
@stevenjcumming stevenjcumming self-assigned this Feb 21, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-flipper-1.2.2/main/main February 21, 2024 16:07 Inactive
@stevenjcumming stevenjcumming merged commit 5ea91af into master Feb 21, 2024
19 of 20 checks passed
@stevenjcumming stevenjcumming deleted the sjc-flipper-1.2.2 branch February 21, 2024 17:18
stevenjcumming added a commit that referenced this pull request Feb 21, 2024
stevenjcumming added a commit that referenced this pull request Feb 21, 2024
* bump flipper gems to 1.2.2

* add recommended flipper indexes and add back precision

---------

Co-authored-by: Steven Cumming <[email protected]>
stevenjcumming added a commit that referenced this pull request Feb 21, 2024
* bump flipper gems to 1.2.2

* add recommended flipper indexes and add back precision

---------

Co-authored-by: Steven Cumming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants