Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remove-va_online_scheduling_appointment_type_consolidation feature toggle #20554

Conversation

JunTaoLuo
Copy link
Contributor

Summary

Related issue(s)

Testing done

  • Relevant unit tests were updated

Screenshots

N/A

What areas of the site does it impact?

Mobile

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

…ture toggle

Ensure enabled logic remains and remove all other unnecessary boilerplate
@JunTaoLuo JunTaoLuo requested review from a team as code owners January 31, 2025 17:20
@JunTaoLuo JunTaoLuo requested a review from ATeal January 31, 2025 17:20
@va-vfs-bot va-vfs-bot temporarily deployed to jtluo/remove-va_online_scheduling_appointment_type_consolidation/main/main January 31, 2025 18:14 Inactive
Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Once this is deployed, you'll need to follow step 3 of this section of this guide to completely remove this toggle. You'll need to do it in the terminal of each ArgoCD environment. If you or no one on your team has access to those terminals, let me know and I can do it for you. Remember, don't delete them in Argo until the code has been deployed.

@JunTaoLuo JunTaoLuo merged commit 6018b97 into master Feb 6, 2025
43 of 44 checks passed
@JunTaoLuo JunTaoLuo deleted the jtluo/remove-va_online_scheduling_appointment_type_consolidation branch February 6, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants