Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBP 90556 Add GH Action to run Yardoc #20555

Closed
wants to merge 11 commits into from

Conversation

wayne-weibel
Copy link
Contributor

@wayne-weibel wayne-weibel commented Jan 31, 2025

Summary

add a github action to run yardoc check on specific directories

Related issue(s)

Add pension yardoc pr action

Testing done

  • New code is covered by unit tests
  • run rake task locally before and after making changes in the action listed directory
  • push to PR to see if the action is triggered

What areas of the site does it impact?

pension and burial

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)

@va-vfs-bot va-vfs-bot temporarily deployed to pbp-90556-yardoc-gh-action/main/main January 31, 2025 18:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pbp-90556-yardoc-gh-action/main/main February 3, 2025 18:22 Inactive
@wayne-weibel wayne-weibel added burial-benefits Label used for Pull Requests that impact Burial claims (530) pension-benefits Used for PRs that impact Pensions labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
burial-benefits Label used for Pull Requests that impact Burial claims (530) pension-benefits Used for PRs that impact Pensions test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants