Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

96452 Add statsd metrics to ProvidersController #20564

Closed

Conversation

PhilipDeFraties
Copy link
Contributor

@PhilipDeFraties PhilipDeFraties commented Jan 31, 2025

Summary

  • Refactored ProviderService#get_provider_service to use with_monitoring

  • Ensures StatsD captures total and failed request metrics automatically

  • Aligns with the existing pattern in AppointmentsService

  • *This work is behind a feature toggle (flipper): NO

Related issue(s)

department-of-veterans-affairs/va.gov-team#96452

Testing done

  • existing tests pass

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@PhilipDeFraties PhilipDeFraties requested review from a team as code owners January 31, 2025 22:51
@va-vfs-bot va-vfs-bot temporarily deployed to 96452_add_statsd_metrics_to_providers_controller/main/main January 31, 2025 23:04 Inactive
@PhilipDeFraties PhilipDeFraties removed the request for review from StevenStraily January 31, 2025 23:19
@randomsync randomsync self-requested a review February 1, 2025 01:25
Copy link
Member

@randomsync randomsync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only going to log a metric on failure, we might want to log it on success as well.

@randomsync randomsync self-requested a review February 1, 2025 01:31
Copy link
Member

@randomsync randomsync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only going to log a metric on failure, we might want to log it on success as well.

- wrap logic in with_monitoring block provided by Common::Client::Concerns::Monitoring#with_monitoring to track successful and failed requests to EPS for provider data
@PhilipDeFraties PhilipDeFraties force-pushed the 96452_add_statsd_metrics_to_providers_controller branch from 140f271 to 527f2a5 Compare February 3, 2025 23:41
@PhilipDeFraties PhilipDeFraties enabled auto-merge (squash) February 4, 2025 00:12
@va-vfs-bot va-vfs-bot temporarily deployed to 96452_add_statsd_metrics_to_providers_controller/main/main February 4, 2025 00:22 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 96452_add_statsd_metrics_to_providers_controller/main/main February 4, 2025 06:05 Inactive
@PhilipDeFraties
Copy link
Contributor Author

closing as per comment in the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants