-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
96452 Add statsd metrics to ProvidersController #20564
96452 Add statsd metrics to ProvidersController #20564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only going to log a metric on failure, we might want to log it on success as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only going to log a metric on failure, we might want to log it on success as well.
- wrap logic in with_monitoring block provided by Common::Client::Concerns::Monitoring#with_monitoring to track successful and failed requests to EPS for provider data
140f271
to
527f2a5
Compare
closing as per comment in the issue |
Summary
Refactored
ProviderService#get_provider_service
to usewith_monitoring
Ensures StatsD captures total and failed request metrics automatically
Aligns with the existing pattern in
AppointmentsService
*This work is behind a feature toggle (flipper): NO
Related issue(s)
department-of-veterans-affairs/va.gov-team#96452
Testing done
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?