[ARP POA Submission] (#4) Status Check Job (#101919) #20696

pixiitech · 2025-02-08T02:37:17Z

Summary

This work is behind a feature toggle (flipper): YES/NO yes
Added job to check status of PoA form submission after AR completes
(What is the solution, why is this the solution?) ⭐ Lighthouse POA API Integration va.gov-team#101919
(Which team do you work for, does your team own the maintenance of this component?) ARF
(If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira ⭐ Lighthouse POA API Integration va.gov-team#101919
Link to previous change of the code/bug (if applicable)
Link to epic if not included in ticket

Testing done

New code is covered by unit tests
Describe what the old behavior was prior to the change The controller did not check status in LH
Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
If this work is behind a flipper:
- Tests need to be written for both the flipper on and flipper off scenarios. Docs.
- What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No error nor warning in the console.
Events are being sent to the appropriate logging solution
Documentation has been updated (link to documentation)
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Feature/bug has a monitor built into Datadog (if applicable)
If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

github-actions · 2025-02-08T02:37:45Z

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/accredited_representative_portal/power_of_attorney_form_submission_job.rb

The base branch was changed.

raudabaugh · 2025-03-05T19:05:47Z

..._portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb

@@ -52,6 +52,7 @@ def load_response_fixture(path_suffix)
  let!(:other_poa_request) { create(:power_of_attorney_request, :with_veteran_claimant, poa_code: other_poa_code) }

  let(:time) { '2024-12-21T04:45:37.000Z' }
+  let(:time_plus_one_day) { '2024-12-22T04:45:37.000Z' }


Is this needed?

raudabaugh · 2025-03-05T19:14:55Z

...app/controllers/accredited_representative_portal/v0/power_of_attorney_requests_controller.rb

+          PENDING = 'pending',
+          PROCESSED = 'processed'
+        ].freeze
+      end


Why the change to public?

raudabaugh · 2025-03-05T19:23:43Z

modules/accredited_representative_portal/spec/factories/power_of_attorney_request.rb

+        )
+      end
+    end
+


Greg mentioned on the call this may have been intended for another PR.

raudabaugh · 2025-03-05T19:28:48Z

...pec/requests/accredited_representative_portal/v0/power_of_attorney_request_decisions_spec.rb

@@ -138,7 +138,7 @@
        expect(response).to have_http_status(:not_found)
        poa_request.reload

-        expect(poa_request.resolution.present?).to be(false)
+        expect(poa_request.resolution.present?).to be(true)


What type of resolution is expected?

raudabaugh · 2025-03-05T19:44:31Z

...al/app/services/accredited_representative_portal/power_of_attorney_request_service/accept.rb

@@ -46,7 +47,6 @@ def call
        raise Error.new(e.message, BenefitsClaims::ServiceException::ERROR_MAP.invert[e.class])
      # Fatal 4xx errors or validation error: save error message, raise FatalError
      rescue *FATAL_ERROR_TYPES => e
-        resolution&.delete


could you link the prior PR you mentioned that contained the regression for context?

@raudabaugh #20747

raudabaugh · 2025-03-05T19:53:44Z

...portal/app/sidekiq/accredited_representative_portal/power_of_attorney_form_submission_job.rb

+    include Sidekiq::Job
+    include SentryLogging
+
+    sidekiq_options retry_for: 48.hours


Noting here that this is a Lighthouse-provided requirement: https://dsva.slack.com/archives/C063D0M76HX/p1739814656787639?thread_ts=1739209607.852849&cid=C063D0M76HX

raudabaugh · 2025-03-05T20:06:17Z

...portal/app/sidekiq/accredited_representative_portal/power_of_attorney_form_submission_job.rb

+    sidekiq_retries_exhausted do |job, _ex|
+      poa_form_submission_id = job['args'].first
+      poa_form_submission = PowerOfAttorneyFormSubmission.find(poa_form_submission_id)
+      poa_form_submission.update(status: :failed, status_updated_at: DateTime.current)


We need to document next steps somewhere for exhausted jobs: either an alternate path for resubmission or escalating the issue through an alert. Once expiration is implemented, the next steps will need to be taken within 60 days.

raudabaugh · 2025-03-05T20:15:02Z

modules/accredited_representative_portal/lib/tasks/seed/staging_seed/methods.rb

@@ -79,6 +74,20 @@ def create_resolution(request, resolution_type)

      private

+      def create_decision_for(request, type)


Greg mentioned on the call this may have been intended for another PR.

raudabaugh · 2025-03-05T20:25:10Z

.../spec/sidekiq/accredited_representative_portal/power_of_attorney_form_submission_job_spec.rb

+          end
+        end
+
+        context 'the job fails 3 times' do


Suggested change

context 'the job fails 3 times' do

context 'the job's retries have exhausted' do

pixiitech changed the base branch from master to art/101919/lighthouse-api-integration February 8, 2025 02:37

github-actions bot added the codeowners-addition-failure label Feb 8, 2025

pixiitech changed the title ~~Art/101919/form submission check job~~ [ARP PoA submission] (#3) form submission check job Feb 8, 2025

github-actions bot added the lint-failure label Feb 8, 2025

va-vfs-bot temporarily deployed to art/101919/form-submission-check-job/main/main February 8, 2025 02:38 Inactive

va-vfs-bot temporarily deployed to art/101919/form-submission-check-job/main/main February 8, 2025 02:46 Inactive

github-actions bot added the test-failure label Feb 8, 2025

va-vfs-bot temporarily deployed to art/101919/form-submission-check-job/main/main February 10, 2025 16:43 Inactive

github-actions bot added test-passing and removed test-failure labels Feb 10, 2025

pixiitech force-pushed the art/101919/lighthouse-api-integration branch from bb62f04 to 81c62b8 Compare February 11, 2025 22:24

pixiitech changed the title ~~[ARP PoA submission] (#3) form submission check job~~ [ARP PoA submission] (#4) form submission check job Feb 11, 2025

pixiitech force-pushed the art/101919/lighthouse-api-integration branch from 81c62b8 to 376a2b6 Compare February 12, 2025 16:41

pixiitech force-pushed the art/101919/form-submission-check-job branch from f99f8c3 to 224b977 Compare February 13, 2025 15:19

va-vfs-bot temporarily deployed to art/101919/form-submission-check-job/main/main February 13, 2025 15:20 Inactive

pixiitech removed the codeowners-addition-failure label Feb 13, 2025

pixiitech changed the base branch from art/101919/lighthouse-api-integration to art/101919/2122-submission-controller-action February 13, 2025 16:10

pixiitech force-pushed the art/101919/form-submission-check-job branch from 224b977 to 441da2d Compare February 13, 2025 16:11

va-vfs-bot temporarily deployed to art/101919/form-submission-check-job/main/main February 13, 2025 16:11 Inactive

github-actions bot removed the lint-failure label Feb 13, 2025

va-vfs-bot temporarily deployed to art/101919/form-submission-check-job/main/main February 13, 2025 16:20 Inactive

github-actions bot added test-failure test-passing and removed test-passing labels Feb 13, 2025

pixiitech removed the test-failure label Feb 13, 2025

nihil2501 added the benefits-accredited-rep-facing label Feb 13, 2025

pixiitech force-pushed the art/101919/2122-submission-controller-action branch 2 times, most recently from 2f63694 to 755ca90 Compare February 19, 2025 15:06

pixiitech force-pushed the art/101919/form-submission-check-job branch from 441da2d to 2a5dfec Compare February 19, 2025 15:24

va-vfs-bot temporarily deployed to art/101919/form-submission-check-job/main/main March 4, 2025 16:23 Inactive

github-actions bot added test-failure and removed test-passing labels Mar 4, 2025

pixiitech marked this pull request as draft March 4, 2025 22:08

Base automatically changed from art/101919/2122-submission-controller-action to master March 5, 2025 16:21

va-vfs-bot temporarily deployed to art/101919/form-submission-check-job/main/main March 5, 2025 16:22 Inactive

pixiitech added 10 commits March 5, 2025 11:55

Create PowerOfAttorneyFormSubmissionJob (#101919)

fafe556

Removed status change on job error

a7138f3

Moved job into module, adjusted job retries to 16

8fa579e

Fix tests

159980d

Update form submission statuses to be in caps

7efaedf

Rebase test fixes

445f81f

Fix and optimize poa request seeds spec

f01d11f

Retry while status is pending

8d940c5

Fix form_submission association, Fix tests again

9fd9721

Keep poa resolution on fatal errors

f278f74

pixiitech force-pushed the art/101919/form-submission-check-job branch from 97fe35a to f278f74 Compare March 5, 2025 17:09

pixiitech requested a review from nihil2501 March 5, 2025 17:09

github-actions bot removed the lint-failure label Mar 5, 2025

va-vfs-bot temporarily deployed to art/101919/form-submission-check-job/main/main March 5, 2025 17:10 Inactive

github-actions bot added test-passing and removed test-failure labels Mar 5, 2025

pixiitech marked this pull request as ready for review March 5, 2025 18:55

github-actions bot added the ready-for-backend-review label Mar 5, 2025

raudabaugh reviewed Mar 5, 2025

View reviewed changes

Changes per code review 3/5

743ebf5

github-actions bot added lint-failure and removed ready-for-backend-review labels Mar 5, 2025

va-vfs-bot deployed to art/101919/form-submission-check-job/main/main March 5, 2025 21:38 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ARP POA Submission] (#4) Status Check Job (#101919) #20696

[ARP POA Submission] (#4) Status Check Job (#101919) #20696

pixiitech commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

raudabaugh Mar 5, 2025

raudabaugh Mar 5, 2025

raudabaugh Mar 5, 2025

raudabaugh Mar 5, 2025

raudabaugh Mar 5, 2025

pixiitech Mar 5, 2025

raudabaugh Mar 5, 2025

raudabaugh Mar 5, 2025

raudabaugh Mar 5, 2025

raudabaugh Mar 5, 2025

		@@ -79,6 +74,20 @@ def create_resolution(request, resolution_type)

		private

		def create_decision_for(request, type)

	context 'the job fails 3 times' do
	context 'the job's retries have exhausted' do

[ARP POA Submission] (#4) Status Check Job (#101919) #20696

Are you sure you want to change the base?

[ARP POA Submission] (#4) Status Check Job (#101919) #20696

Conversation

pixiitech commented Feb 8, 2025

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Requested Feedback

github-actions bot commented Feb 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment