-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VI-1012] adds SiS pkey jwt ClientConfig seed #20855
Open
bramleyjl
wants to merge
5
commits into
master
Choose a base branch
from
VI-1012_sis_pkey_jwt_seed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c12b86e
to
57e850f
Compare
RachalCassity
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SignIn::ClientConfig
for private key JWT clientsRelated issue(s)
Testing done
Token request testing
bin/rails db:seed
/authorize
endpoint with thesample_client_pkey_jwt
client id & authenticatecode
URL parameter into the Postman collection as thesis_client-auth_code
variable & make aSign In Service / Client Auth (User) / Private Key JWT Auth / token
request - you should receive a 200 response with access & refresh tokensToken usage testing
vets-api/app/controllers/concerns/authentication_and_sso_concerns.rb
to allow thesample_client_pkey_jwt
client id to access authenticated routesvets-api / User / ICN
call - you should receive a 200 response