Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10-10EZ] Add download_pdf endpoint for 10-10EZ #20968

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

coope93
Copy link
Contributor

@coope93 coope93 commented Feb 25, 2025

Summary

  • This work is behind a feature toggle (flipper): NO
  • Add new download_pdf endpoint in the health_care_applications_controller that receives a post body of form data and generates and fills out a 10-10EZ form pdf that is returned in the response.
  • 1010 Health Apps

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main February 25, 2025 21:52 Inactive
@coope93 coope93 changed the title add new download_pd endpoint to hca controller [10-10EZ] Add download_pdf endpoint for 10-10EZ Feb 26, 2025
@coope93 coope93 marked this pull request as ready for review February 26, 2025 14:08
@coope93 coope93 requested review from a team as code owners February 26, 2025 14:08
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main February 26, 2025 14:09 Inactive
JoshingYou1
JoshingYou1 previously approved these changes Feb 26, 2025
Copy link
Contributor

@JoshingYou1 JoshingYou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we want to add this new route to the swagger docs?

@coope93
Copy link
Contributor Author

coope93 commented Feb 26, 2025

LGTM! Do we want to add this new route to the swagger docs?
Yep, good callout on that. Thanks!

@coope93 coope93 requested a review from JoshingYou1 February 26, 2025 15:36
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main February 26, 2025 15:37 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main February 26, 2025 17:33 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main February 27, 2025 14:17 Inactive
@coope93 coope93 force-pushed the 102897-add-1010ez-pdf-endpoint branch from 78228f3 to 18d83bf Compare February 27, 2025 19:24
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main February 27, 2025 19:25 Inactive
@coope93 coope93 force-pushed the 102897-add-1010ez-pdf-endpoint branch from 18d83bf to 04ca1a5 Compare February 28, 2025 13:44
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main February 28, 2025 13:46 Inactive
@coope93 coope93 requested a review from Mitch-A6 February 28, 2025 14:03
@coope93 coope93 force-pushed the 102897-add-1010ez-pdf-endpoint branch from 04ca1a5 to 24dc1cf Compare February 28, 2025 17:48
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main February 28, 2025 17:49 Inactive
@coope93 coope93 force-pushed the 102897-add-1010ez-pdf-endpoint branch from 24dc1cf to a38e6e0 Compare February 28, 2025 20:57
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main February 28, 2025 20:58 Inactive
@coope93 coope93 force-pushed the 102897-add-1010ez-pdf-endpoint branch from a38e6e0 to 951b375 Compare March 3, 2025 15:59
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main March 3, 2025 16:00 Inactive
@coope93 coope93 force-pushed the 102897-add-1010ez-pdf-endpoint branch from 951b375 to de8c033 Compare March 3, 2025 20:19
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main March 3, 2025 20:22 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main March 3, 2025 21:02 Inactive
@rjohnson2011 rjohnson2011 self-requested a review March 3, 2025 21:30
Copy link
Contributor

@rjohnson2011 rjohnson2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some PDF errors in the tests. Rerunning to see if anything changes.

@rjohnson2011
Copy link
Contributor

Just updated the branch to see if that helps the failing test.

@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main March 3, 2025 23:14 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main March 4, 2025 16:26 Inactive
@coope93 coope93 force-pushed the 102897-add-1010ez-pdf-endpoint branch from f1552c8 to cc4b97c Compare March 5, 2025 15:14
@va-vfs-bot va-vfs-bot temporarily deployed to 102897-add-1010ez-pdf-endpoint/main/main March 5, 2025 15:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants