253 | mobile vshe connection

[mtharmer-wc]

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

• This work is behind a feature toggle (flipper): YES/NO
  No
• (Summarize the changes that have been made to the platform)
  This PR adds a route to fetch a veteran's title 38 status from the VeteranVerification service and serve that route up to the mobile application.
• (If bug, how to reproduce)
  Not a bug
• (What is the solution, why is this the solution?)
• (Which team do you work for, does your team own the maintenance of this component?)
  Mobile Feature Support - yes, MFS is a codeowner
• (If introducing a flipper, what is the success criteria being targeted?)
  No new flippers

Related issue(s)

• Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira
  https://github.com/department-of-veterans-affairs/va-mobile-feature-support/issues/253
• Link to previous change of the code/bug (if applicable)
• Link to epic if not included in ticket

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[ATeal]

Does this need to include anything about the notConfirmedReason?

[mtharmer-wc]

@ATeal I don't believe there's a way to include optional properties, and notConfirmedReason is optional, only appearing when status is 'not confirmed'. I did set the additionalProperties: true statement to show that other properties are allowed

[ATeal]

Similar question as the schema do we need to include anything about the notConfirmedReason

[ATeal]

Looks good to me 👍