Add error logging for SendNotificationEmailJob #21028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
logging-for-benefits-intake-status-job/main/main
Thrillberg
force-pushed
the
logging-for-benefits-intake-status-job
branch
from
9f499d2 to
51a49d7
Compare
va-vfs-bot
temporarily deployed
to
logging-for-benefits-intake-status-job/main/main
va-vfs-bot
temporarily deployed
to
logging-for-benefits-intake-status-job/main/main
va-vfs-bot
temporarily deployed
to
logging-for-benefits-intake-status-job/main/main
rjohnson2011
requested changes
Mar 4, 2025
| def handle_exception(e) | ||
| Rails.logger.error( | ||
| 'Error sending simple forms notification email', | ||
| message: e.message, |
There was a problem hiding this comment.
Want to confirm there's no possibility for PII / sensitive information being leaked in this log.
There was a problem hiding this comment.
Nope this should be good for PII. The error message would not include PII unless it somehow accesses the form data from inside the form submission on its own.
va-vfs-bot
temporarily deployed
to
logging-for-benefits-intake-status-job/main/main
va-vfs-bot
temporarily deployed
to
logging-for-benefits-intake-status-job/main/main
va-vfs-bot
temporarily deployed
to
logging-for-benefits-intake-status-job/main/main
va-vfs-bot
temporarily deployed
to
logging-for-benefits-intake-status-job/main/main
va-vfs-bot
temporarily deployed
to
logging-for-benefits-intake-status-job/main/main
rjohnson2011
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds error logging for the Simple Forms
SendNotificationEmailJob, which I think will illuminate an error we're seeing in the Benefits Intake Status Job.