Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flag: disability_526_max_cfi_service_switch #21080

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dfitchett
Copy link
Contributor

@dfitchett dfitchett commented Mar 4, 2025

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

Related issue(s)

Testing done

Tests updated in referenced PR above

What areas of the site does it impact?

None

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@dfitchett dfitchett requested review from a team as code owners March 4, 2025 18:39
@dfitchett dfitchett changed the title Remove feature flag from code. References were removed in #21036 Remove feature flag: disability_526_max_cfi_service_switch Mar 4, 2025
@dfitchett dfitchett requested a review from asiisii March 4, 2025 18:40
asiisii
asiisii previously approved these changes Mar 4, 2025
Copy link
Contributor

@asiisii asiisii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@va-vfs-bot va-vfs-bot temporarily deployed to dfitchett/remove-disability_526_max_cfi_service_switch-feature-flag/main/main March 4, 2025 18:51 Inactive
@dfitchett dfitchett mentioned this pull request Mar 4, 2025
8 tasks
@va-vfs-bot va-vfs-bot temporarily deployed to dfitchett/remove-disability_526_max_cfi_service_switch-feature-flag/main/main March 5, 2025 20:43 Inactive
@dfitchett dfitchett force-pushed the dfitchett/remove-disability_526_max_cfi_service_switch-feature-flag branch from 8361acd to 6e4c19d Compare March 5, 2025 20:47
@va-vfs-bot va-vfs-bot temporarily deployed to dfitchett/remove-disability_526_max_cfi_service_switch-feature-flag/main/main March 5, 2025 20:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dfitchett/remove-disability_526_max_cfi_service_switch-feature-flag/main/main March 5, 2025 21:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the max ratings api switch feature flag
5 participants