Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VI-1119] - Create IdentitySettings #21088

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[VI-1119] - Create IdentitySettings #21088

wants to merge 1 commit into from

Conversation

rileyanderson
Copy link
Contributor

@rileyanderson rileyanderson commented Mar 4, 2025

Summary

  • Create IdentitySettings for identity owned config.
  • settings.yml contains defaults
  • each environment overrides or uses the default value
  • a ~ is a secret value that will be injected from parameter store

Related issue(s)

Testing

  • Check IdentitySettings in console

What areas of the site does it impact?

Settings

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@va-vfs-bot va-vfs-bot temporarily deployed to vi-1119/main/main March 4, 2025 21:42 Inactive
Copy link

github-actions bot commented Mar 4, 2025

1 Warning
⚠️ This PR changes 276 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • .github/CODEOWNERS (+3/-1)

  • .gitignore (+2/-1)

  • config/identity_settings/environments/dev.yml (+50/-0)

  • config/identity_settings/environments/localhost.yml (+2/-0)

  • config/identity_settings/environments/production.yml (+70/-0)

  • config/identity_settings/environments/staging.yml (+56/-0)

  • config/identity_settings/settings.yml (+89/-0)

  • config/initializers/identity_config.rb (+2/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@rileyanderson rileyanderson changed the title Create IdentitySettings [VI-1119] - Create IdentitySettings Mar 4, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to vi-1119/main/main March 4, 2025 22:00 Inactive
@rileyanderson rileyanderson requested a review from a team March 4, 2025 22:21
@rileyanderson rileyanderson marked this pull request as ready for review March 4, 2025 22:22
@rileyanderson rileyanderson requested a review from a team as a code owner March 4, 2025 22:22
@va-vfs-bot va-vfs-bot temporarily deployed to vi-1119/main/main March 4, 2025 22:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants