Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21p_527ez setting hardcoded to ENV #21096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

21p_527ez setting hardcoded to ENV #21096

wants to merge 1 commit into from
+1 −1

Conversation

stevenjcumming
Copy link
Contributor

Summary

  • Setting for vanotify/services/21p_527ez/email/received/template_id was hardcoded but should now be ENV
  • All Parameters exist
  • SETTINGS__ override parameters should be removed just before deploy

Related issue(s)

  • n/a

Testing done

  • [ ]

Acceptance criteria

  • setting uses ENV
  • all parameters exists

@stevenjcumming stevenjcumming self-assigned this Mar 5, 2025
@stevenjcumming stevenjcumming requested review from a team as code owners March 5, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stevenjcumming stevenjcumming

Labels
ready-for-backend-review require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjcumming @va-vfs-bot