Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] : SurveyBookmark 변경감지가 동작하지 않는 버그 수정 #378

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

devxb
Copy link
Member

@devxb devxb commented Feb 25, 2024

어떤 기능을 개발했나요?

Survey에 북마크를 해도 변경감지가 동작하지 않아서, 반영되지 않는 버그를 수정했습니다.

어떻게 해결했나요?

  • SurveyBookmarkPort 생성 및 구현
  • lombok의 Builder 사용시, @Builder.Default 가 없으면 다른값을 넣을 수 없어서, @Builder.Default 추가
  • EntityMapper에 bookmark 매핑 추가

이슈 넘버

참고자료

Copy link

public static Set<SurveyBookmark> toSurveyBookmark(Set<SurveyBookmarkEntity> surveyBookmarkEntities) {
return surveyBookmarkEntities.stream()
.map(surveyBookmarkEntity -> new SurveyBookmark(surveyBookmarkEntity.getSurveyId()))
.collect(Collectors.toSet());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

17에 toSet() 있지 않나? 요건 11 표현식 같은데

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toList만 있을걸??
나도 방금 . 찍어봤는데 안보이긴하네

스크린샷 2024-02-26 오전 9 25 24

@devxb devxb merged commit 860c61f into main Feb 26, 2024
5 checks passed
@devxb devxb deleted the devxb/iss-#377 branch February 26, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] : SurveyBookmark가 동작하지 않는 버그 수정
2 participants