[refactor] : login된 유저 조회 api가 email을 함께 반환하도록 수정 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojinyou
reviewed
Mar 8, 2024
user/user-application/src/main/java/me/nalab/user/application/common/dto/TokenInfo.java
Outdated
Show resolved
Hide resolved
...pplication/src/main/java/me/nalab/user/application/service/LoginedUserGetByTokenService.java
Outdated
Show resolved
Hide resolved
dojinyou
reviewed
Mar 17, 2024
| @@ -58,7 +58,7 @@ void REPLACE_BOOKMARK_SUCCESS_TEST() throws Exception { | |||
|
|
|||
| // given | |||
| Long targetId = targetInitializer.saveTargetAndGetId("target", Instant.now()); | |||
| String token = "token"; | |||
| String token = "bearer token"; | |||
There was a problem hiding this comment.
토큰 만드는 책임을 넘기거나 Authentication Type을 public static 으로 풀면 좋을 것 같음!
| String email | ||
| ) { | ||
|
|
||
| public static LoginedInfo from(Long targetId, User user) { |
There was a problem hiding this comment.
parameter가 복수개라면 of?
Suggested change
| public static LoginedInfo from(Long targetId, User user) { | |
| public static LoginedInfo of(Long targetId, User user) { |
dojinyou
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.