Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

로그인 페이지에서 검증 지연 문제 해결 #613

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

ddarkr
Copy link
Collaborator

@ddarkr ddarkr commented Feb 18, 2024

⛳️작업 내용

  • email, password form에 debounce가 적용되어 검증을 만족함에도 한박자 느리게 처리되는 문제를 해결합니다.
    • 입력 검증에 큰 비용이 소모되지 않을 것이라 판단하여, debounce를 없애버렸습니다.
      image

📸스크린샷

⚡️사용 방법

📎레퍼런스

Copy link

Bundle Sizes

Compared against none

Route Size (gzipped)
/ 106.29 KB
/_app 216.97 KB
/_error 77.85 KB
/add/image 98.85 KB
/add/link 101.32 KB
/add/share 78.08 KB
/add/tag 85.4 KB
/add/text 99.47 KB
/content 100.39 KB
/edit/tag 85.56 KB
/login 83.01 KB
/my 85.95 KB
/my/account 83.31 KB
/my/account/change-nickname 82.52 KB
/my/account/change-password 82.81 KB
/my/tag 89.83 KB
/my/tag/AddTagBottomSheet 85.02 KB
/onboard 81.54 KB
/password 82.77 KB
/password/sent-email 79.37 KB
/password/verified 78.69 KB
/privacy 77.69 KB
/signup 86.89 KB
/signup/email-verified 83.89 KB
/signup/information 84.02 KB
/signup/sent-email 81.11 KB
/tag 83.91 KB
Dynamic import Size (gzipped)
../../.yarn/cache/@tanstack-query-devtools-npm-5.18.1-9c6902de16-7514ad0eb5.zip/node_modules/@tanstack/query-devtools/build/index.js -> ./Devtools/IEC7B7YJ.js no change
../components/home/FilterBottomSheetModal/FilterBottomSheetModal.tsx -> ~/components/home/TagFormRouteAsModal 3.88 KB
../components/inspiration/ImageView.tsx -> ~/components/add/AddTagFormRouteAsModal 2.83 KB
../components/inspiration/LinkView.tsx -> ~/components/add/AddTagFormRouteAsModal 2.83 KB
../components/inspiration/TextView.tsx -> ~/components/add/AddTagFormRouteAsModal 2.83 KB
add/image.tsx -> ~/components/add/AddTagFormRouteAsModal 2.73 KB
add/link.tsx -> ~/components/add/AddTagFormRouteAsModal 2.64 KB
add/text.tsx -> ~/components/add/AddTagFormRouteAsModal 2.64 KB
content/index.tsx -> ~/components/common/IllustDialog 741 B
content/index.tsx -> ~/components/edit/EditTagFormRouteAsModal 2.9 KB
index.tsx -> ~/components/edit/EditTagFormRouteAsModal 5.01 KB
index.tsx -> ~/components/inspiration/InspirationViewAsModal 13.99 KB

Copy link
Member

@hyesungoh hyesungoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 👍 👍 👍 고생하셨습니다 👍 👍

@ddarkr ddarkr merged commit 6d0e7f2 into develop Feb 18, 2024
5 of 8 checks passed
@ddarkr ddarkr deleted the fix/auth-login-debounce-issue branch February 18, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants