Amount is optional according to the guidelines #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sounds good, let's make it optional. |
derhuerst
requested changes
Oct 22, 2023
| @@ -77,7 +79,7 @@ const generateQrCode = data => { | |||
| data.bic, | |||
| data.name, | |||
| serializeIBAN(data.iban), | |||
| 'EUR' + data.amount.toFixed(2), | |||
| data.amount ? 'EUR' + data.amount.toFixed(2) : data.amount, | |||
There was a problem hiding this comment.
This will not put EUR if data.amount is 0.
There was a problem hiding this comment.
Hi @derhuerst ,
If amount is 0 an error is thrown from a few lines above 'data.amount must be >=0.01 and <=999999999.99.'.
Best,
Tamas
|
Thanks! Do you want to be mentioned as a contributor in |
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @derhuerst ,
According to the guidelines from the readme, the amount is optional.
For my use case, it makes sense, mostly I'd like to share just the name/IBAN via a QR and fill in the amount later.
I was testing with my Revolut app, which worked properly without the amount as well.
Let me know what do you think.
Cheers,
Tamas