Feature: support language-specific field defaults #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
feature/698-translated-model-field-default
branch
from
dd6f8f2
to
41d7db6
Compare
sergei-maertens
commented
Sep 4, 2023
sergei-maertens
force-pushed
the
feature/698-translated-model-field-default
branch
from
41d7db6
to
5f94bd8
Compare
sergei-maertens
commented
Sep 4, 2023
sergei-maertens
force-pushed
the
feature/698-translated-model-field-default
branch
from
5f94bd8
to
89a5c67
Compare
|
Migration fixes applied here too |
|
Merged migration fixes, now please rebase this branch or merge master into it to resolve conflicts. |
|
Sure, I'll be in the office in 30 mins and you can expect the rebase then |
…#698) The expectation is that for every language/translation field, its language gets activated before evaluating the default callable.
sergei-maertens
force-pushed
the
feature/698-translated-model-field-default
branch
from
89a5c67
to
836daa0
Compare
|
@last-partizan I've rebased and rewritten the commit messages to use conventional commit |
|
Looks fine, but gitlab-ci is failing for the reasons unrelated to this PR. I'll try running it again later today. If that doesn't work, i'll test it locally and merge tomorrow. |
sergei-maertens
force-pushed
the
feature/698-translated-model-field-default
branch
from
79891da
to
836daa0
Compare
|
Is there anything else you want to check or fix before merging? It looks fine to me, and i plan merge it tomorrow. |
|
No, let's go for it!
…On Thu, 7 Sep 2023, 14:51 Serhii Tereshchenko, ***@***.***> wrote:
Is there anything else you want to check or fix before merging?
It looks fine to me, and i plan merge it tomorrow.
—
Reply to this email directly, view it on GitHub
<#700 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKDJVU3YH44LKC2FR6ZANTXZG7NNANCNFSM6AAAAAA4EOS4UE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #698, overlaps with #699 w/r to re-generated initial migrations
When django-modeltranslation creates the translation fields (foo_en, foo_de...) and the base field has a callable default set, any language-aware content is now translated with the field's language.
The mechanism is rather simple -
Field.get_defaultis overridden to temporarily activatefield.language.