Add support for version string corner cases. #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a wide variety of valid version strings to be parsed by
desiutil.setup.get_version()
.While developing this, it was discovered that
desiutil.dust.ext_fitzpatrick()
requiresscipy
, but this requirement had never been explicitly listed. It appears that previously, one or more of astropy, healpy or matplotlib would bring in a dependency on scipy, but more recent versions do not have that dependency, so scipy has to be installed explicitly.