Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix miscellaneous bugs present in 3.1.1 #206

Merged
merged 6 commits into from
Jan 7, 2025
Merged

fix miscellaneous bugs present in 3.1.1 #206

merged 6 commits into from
Jan 7, 2025

Conversation

moustakas
Copy link
Member

Y3/Loa processing began about a day ago, revealing a handful of corner-case bugs that this PR fixes, mostly due to masked cameras.

Longer-term, the data used for our unit tests should include data with warts.

@coveralls
Copy link

coveralls commented Jan 7, 2025

Pull Request Test Coverage Report for Build 12658479148

Details

  • 13 of 22 (59.09%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 49.614%

Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/linemasker.py 10 14 71.43%
py/fastspecfit/emlines.py 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
py/fastspecfit/emlines.py 1 80.14%
Totals Coverage Status
Change from base Build 12623102823: -0.007%
Covered Lines: 3216
Relevant Lines: 6482

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12658479148

Details

  • 13 of 22 (59.09%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 49.614%

Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/linemasker.py 10 14 71.43%
py/fastspecfit/emlines.py 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
py/fastspecfit/emlines.py 1 80.14%
Totals Coverage Status
Change from base Build 12623102823: -0.007%
Covered Lines: 3216
Relevant Lines: 6482

💛 - Coveralls

@moustakas moustakas merged commit 0b524d2 into main Jan 7, 2025
@moustakas moustakas deleted the fix-3.1.1-bugs branch January 7, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants