Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiberloss method is updated for dithering simulations #103

Closed
wants to merge 2 commits into from

Conversation

tolgayapici
Copy link

the previous branch, dithering, was off sync with master and would be hard to resolve the conflicts. created a new branch out of master and added the features needed for dithering simulations.

@sbailey sbailey requested a review from dkirkby April 8, 2019 19:59
@sbailey
Copy link
Contributor

sbailey commented Apr 8, 2019

@dkirkby could you take a look at the failing Travis tests? They appear to be related to matplotlib / astropy / numpy version incompatibilities, and not directly to this code update (and not just Travis hiccups either).

In addition to the Travis tests, could you also review this PR for merging? Thanks.

@weaverba137
Copy link
Member

@tolgayapici, @dkirkby, does this PR supersede #73?

@dkirkby
Copy link
Member

dkirkby commented Aug 4, 2020

I suspect this PR is no longer relevant but @tolgayapici should confirm.

@sybenzvi
Copy link

sybenzvi commented Aug 5, 2020

@dkirkby and @weaverba137, Tolga left DESI at the end of November 2019 and is not maintaining the branch. Given the progress Eddie made using actual dither data we don't really need to merge this into the master. You can close the PR but I suggest keeping the branch around just in case.

@weaverba137
Copy link
Member

Closing PR based on @sybenzvi's advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants