Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 support #275

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Add Python 3.13 support #275

merged 5 commits into from
Jan 30, 2025

Conversation

jank324
Copy link
Member

@jank324 jank324 commented Oct 9, 2024

Description

Adds Python 3.13 to the versions tested and upgrades all other test and format check runs (different OSs, flake8, black etc.) to run on 3.13.

Motivation and Context

Python 3.13 was released two days ago. Closes #271.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code and checked that formatting passes (required).
  • I have have fixed all issues found by flake8 (required).
  • I have ensured that all pytest tests pass (required).
  • I have run pytest on a machine with a CUDA GPU and made sure all tests pass (required).
  • I have checked that the documentation builds (required).

Note: We are using a maximum length of 88 characters per line.

@jank324 jank324 linked an issue Oct 9, 2024 that may be closed by this pull request
@jank324 jank324 self-assigned this Oct 9, 2024
@jank324
Copy link
Member Author

jank324 commented Oct 9, 2024

We are keeping this in draft for now because it seems at least one dependency isn't compatible with Python 3.13 yet.

@jank324
Copy link
Member Author

jank324 commented Oct 9, 2024

Specifically the issue is PyTorch, and 3.13 support there is only expected for v2.6 (pytorch/pytorch#130249).

@jank324
Copy link
Member Author

jank324 commented Jan 28, 2025

PyTorch 2.6 should be released tomorrow. I just ran a local test with the RC and everything seems to work fine.

@jank324 jank324 marked this pull request as ready for review January 29, 2025 17:26
@jank324 jank324 requested a review from Hespe January 29, 2025 17:26
@jank324 jank324 merged commit 0636048 into master Jan 30, 2025
8 checks passed
@jank324 jank324 deleted the 271-add-python-313-support-tests branch January 30, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.13 support / tests
2 participants