-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space charge tests: improve backward-mode test ; add forward-mode test #339
Open
RemiLehe
wants to merge
11
commits into
desy-ml:master
Choose a base branch
from
RemiLehe:forward_mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
commented
Feb 9, 2025
num_particles=torch.tensor(10_000), | ||
sigma_px=torch.tensor(2e-7), | ||
sigma_py=torch.tensor(2e-7), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reusing the same code as in the test test_cold_uniform_beam_expansion
above.
Thanks for providing a forward AD test. I think similar tests could also be added to other parts, but we can do that in a separate PR. |
RemiLehe
commented
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the space-charge tests:
Motivation and Context
Since Cheetah is built with
pytorch
, it supports backward-differentiation, but also forward differentiation (see this page). This could be useful since the scaling of forward differentiation is different from that of backward differentiation.In addition, previous tests of backward-differentiation mode were simply checking that the differentiation ran without error, but they did not check the accuracy of the computed gradient. In this PR, we now test the accuracy of the gradient, by reusing the parameters of https://accelconf.web.cern.ch/hb2023/papers/thbp44.pdf, and by using an analytical formula to find the expected gradient.
Types of changes
New test
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).