refactor safeguards module #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please look at this @robertodr? (we need to move this to own org so that I can suggest you as reviewer) |
robertodr
approved these changes
Apr 10, 2018
|
Good point I need to check that. Yes, the versioning needs some more thinking. |
|
Autocmake as a curated repository of utilities sounds doable. Handling everything from 2.8.z to 3.y.z is anyway unrealistic... |
|
Created #243 to discuss this. |
|
Indeed fails with 2.8 - thanks for catching this. I will park this PR until we decide how we deal with versions. |
|
We are now in the future. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.