Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature : 웨이팅 생성 시 동시성 구현하기 #109

Merged
merged 13 commits into from
Jan 17, 2024
Merged

feature : 웨이팅 생성 시 동시성 구현하기 #109

merged 13 commits into from
Jan 17, 2024

Conversation

hyun2371
Copy link
Member

⛏ 작업 상세 내용

  • 대기 번호 생성 및 조회 로직 변경 (락 걸기 위함)
    • shop 엔티티 waitingCount 필드 추가
    • 엔티티 내 waitingCount 증가 메서드 추가
    • repository 사용하지 않는 함수 제거
  • 비관적 락으로 shop 엔티티 조회 메서드 추가
    • repository 테스트 진행

📝 작업 요약

  • Shop 필드 추가
  • 대기 번호 생성 로직 변경
  • shopEntity 조회 메서드 비관적 락 추가

☑️ 중점적으로 리뷰 할 부분

  • shopRepository

@hyun2371 hyun2371 self-assigned this Jan 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

Test Results

130 tests  +1   127 ✅ ±0   9s ⏱️ ±0s
 34 suites +1     3 💤 +1 
 34 files   +1     0 ❌ ±0 

Results for commit e8a25f9. ± Comparison against base commit 46bdd9e.

♻️ This comment has been updated with latest results.

dlswns2480
dlswns2480 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@dlswns2480 dlswns2480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~
락이 매장 조회할 때 걸린이유가 waitingCount 조회시에 원자성 보장하려 한거 맞겠죠??

@hyun2371 hyun2371 force-pushed the feat/#103/create-waiting-concurrency branch from 32f5d5d to a9c0d78 Compare January 17, 2024 04:16
kkangh00n
kkangh00n approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@kkangh00n kkangh00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~! CI 테스트만 해결하면 될 것 같아요!

@hyun2371 hyun2371 force-pushed the feat/#103/create-waiting-concurrency branch from 4078cea to 14d351f Compare January 17, 2024 09:59
@hyun2371 hyun2371 force-pushed the feat/#103/create-waiting-concurrency branch from e91694a to e8a25f9 Compare January 17, 2024 12:23
@hyun2371 hyun2371 merged commit de44359 into dev Jan 17, 2024
3 checks passed
@hyun2371 hyun2371 linked an issue Jan 17, 2024 that may be closed by this pull request
feature : 웨이팅 생성 시 동시성 구현하기 #108
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlswns2480 dlswns2480 dlswns2480 approved these changes

@kkangh00n kkangh00n kkangh00n approved these changes

Assignees

@hyun2371 hyun2371

Labels
feature
Projects
Catch Table
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature : 웨이팅 생성 시 동시성 구현하기
3 participants
@hyun2371 @dlswns2480 @kkangh00n