Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

대기 생성 API 수정 및 보완 #41

Merged
merged 12 commits into from
Jan 3, 2024
Merged

Conversation

hyun2371
Copy link
Member

@hyun2371 hyun2371 commented Jan 2, 2024

⛏ 작업 상세 내용

  • 충돌 해결

    • 기존 커밋 날리고 재 커밋 및 푸시
  • waitingOrder 필드 삭제

    • 엔티티, service, dto, service test code 수정
  • 엔티티 Waiting 필드명 수정

    • delayRemainingCount -> postponeRemainingCount
  • 서비스 코드 잘못된 로직 수정

    • waitingNumber, waitingOrder 서로 다른 값 대입한 것 수정
  • 컨트롤러 통합 테스트 작성

  • MemberFixture 파라미터 수정

    • name 아닌 email 넘겨주도록
  • WaitingFixture 생성

    • 웨이팅 입장, 기본 웨이팅 fixture 생성
    • WaitingRepositoryTest 에서 사용

📝 작업 요약

  • Waiting Entity 필드 수정
  • 통합 테스트 작성
  • Fixture 생성 및 수정

☑️ 중점적으로 리뷰 할 부분

  • waitingRepositoryTest

@hyun2371 hyun2371 self-assigned this Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

Test Results

10 files  +1  10 suites  +1   5s ⏱️ ±0s
17 tests +2  17 ✅ +2  0 💤 ±0  0 ❌ ±0 
17 runs  +1  17 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 8e56a2b. ± Comparison against base commit 561e7b8.

♻️ This comment has been updated with latest results.

@hyun2371 hyun2371 closed this Jan 2, 2024
@hyun2371 hyun2371 reopened this Jan 2, 2024
Copy link
Collaborator

@kkangh00n kkangh00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셔쑤다..!!

@hyun2371 hyun2371 force-pushed the feat/#37/waiting-create-api2 branch from 2aed36e to 053d1d9 Compare January 3, 2024 05:35
@hyun2371 hyun2371 force-pushed the feat/#37/waiting-create-api2 branch from 16da22a to 8e56a2b Compare January 3, 2024 05:46
@dlswns2480 dlswns2480 merged commit b35b28f into dev Jan 3, 2024
3 checks passed
@hyun2371 hyun2371 deleted the feat/#37/waiting-create-api2 branch January 4, 2024 13:22
@hyun2371 hyun2371 linked an issue Jan 17, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feature : 대기 생성 API 수정 및 보완
3 participants