feat: Add configurable conda-forge URL #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement _get_conda_forge_url method to read URL from config - Replace hardcoded CONDA_FORGE_TUNA with configurable URL - Remove unused CONDA_FORGE constant and comments
kagami-l
reviewed
Sep 20, 2024
devchat/workflow/env_manager.py
Outdated
Comment on lines
272
to
273
| config_file = os.path.expanduser("~/.chat/config.yml") | ||
| default_url = "https://mirrors.tuna.tsinghua.edu.cn/anaconda/cloud/conda-forge/" |
There was a problem hiding this comment.
文件路径用 path.py 里的这个常量，方便统一处理
https://github.com/devchat-ai/devchat/blob/main/devchat/workflow/path.py#L8
default_url 也保留常量形式吧
devchat/workflow/env_manager.py
Outdated
| return config.get("conda-forge-url", default_url) | ||
| except Exception as e: | ||
| # Log the exception if needed | ||
| print(f"An error occurred: {e}") |
There was a problem hiding this comment.
这里的print都会打到聊天栏里，确定要打error信息？
这里出错不会直接导致操作失败，用logger输出到日志文件就行，等后面安装失败，会提示查看日志文件
There was a problem hiding this comment.
按道理来说，不应该有异常发生，这里一旦发生异常，可能会是很重要的信息发生了错误。显示到聊天栏中，不影响继续执行情况下，可以让用户更加关注下。
- Add DEFAULT_CONDA_FORGE_URL constant - Update get_conda_forge_url method to use CHAT_DIR - Improve error handling and default URL usage
kagami-l
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable conda-forge URL to replace the hardcoded CONDA_FORGE_TUNA URL. It implements a new
_get_conda_forge_urlmethod to read the URL from the configuration, removes the unused CONDA_FORGE constant, and cleans up related comments.Changes:
_get_conda_forge_urlmethod to read URL from configThis change allows for more flexibility in specifying the conda-forge URL, which can be useful for different environments or configurations.