Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a url change in getBaseUrl #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

a url change in getBaseUrl #67

wants to merge 1 commit into from

Conversation

nothatDinger
Copy link

No description provided.

@develar
Copy link
Owner

develar commented Sep 14, 2021

Could you please explain why this change is required?

@nothatDinger
Copy link
Author

The old one is invalid now.
I am using other project which is relying on your project.But meet some problem.
You can refer it from this url:electron-userland/electron-builder#6249 (comment)
I think it is because the api of github has changed.

@mquevill
Copy link
Contributor

GitHub itself recommends using the download link instead of the tag link: https://docs.github.com/en/repositories/releasing-projects-on-github/linking-to-releases

Changes made in #74 may help to fix this problem instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nothatDinger @develar @mquevill