-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lifecycle doc proposal #1286
Conversation
Signed-off-by: Kim Tsao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
==========================================
- Coverage 35.79% 35.75% -0.05%
==========================================
Files 52 52
Lines 6679 6696 +17
==========================================
+ Hits 2391 2394 +3
- Misses 4144 4158 +14
Partials 144 144 ☔ View full report in Codecov by Sentry. |
This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days. |
Signed-off-by: thepetk <[email protected]>
@elsony @amisevsk @yangcao77 & @johnmcollier fyi the devfile/registry#208 is merged. I've noticed we had this PR too opened so we can track the process of the proposal. IMO it would be a good thing to link the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We could merge this for archival sake, also a link to our registry lifecycle from here. We could also include something like this in one of our other devfile api docs which make mention of the devfile registry. What does everybody else think?
cc: @elsony |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johnmcollier, kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
"Converts" the existing PR to a proposal as discussed in today's stand-up. We can't publish the doc until stories in the Epic are done so we will park it as a proposal and wait for more feedback for now
Which issue(s) does this PR fix
#1066
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer