Add MacOS support for typescript model build script #1457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for recognizing if the user running the script is on MacOS. Due to the fact that some commands work differently if they are on freeBSD (Mac) or GNU/Linux.
The changes include:
realpath
is used for Darwin andreadlink -m
is used for everything else.sed
command to ensure it works for all users.Which issue(s) does this PR fix
fixes #1380
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer
Try and build the typescript model by running
bash ./build/typescript-model/generate.sh
from the root of the api repo.