Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up upload-artifact action #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Jan 31, 2025

Description of Changes

Updates the upload-artifact action as its version is no longer supported.

Related Issue(s)

Partially fixes devfile/api#1675

Acceptance Criteria

  • Unit Tests
  • E2E Tests
  • Documentation
    Update the sidebar if there is a new file added or an existing filename is changed

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thepetk Need you to sign off to fix DCO

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after DCO is fixed

Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk force-pushed the patch-upload-artifact branch from b93b537 to de59619 Compare January 31, 2025 15:47
@openshift-ci openshift-ci bot removed the lgtm label Jan 31, 2025
Copy link

openshift-ci bot commented Jan 31, 2025

New changes are detected. LGTM label has been removed.

@thepetk
Copy link
Contributor Author

thepetk commented Jan 31, 2025

fff you go through github UI to fix something simple and then you take double the time to fix what you have added :D

signed :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Scorecard Workflow Dependency
3 participants