Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REAME and CONTRIBUTING updates #1349

Merged
merged 3 commits into from
Nov 12, 2024
Merged

REAME and CONTRIBUTING updates #1349

merged 3 commits into from
Nov 12, 2024

Conversation

l0rd
Copy link
Collaborator

@l0rd l0rd commented Nov 11, 2024

What does this PR do?

  • Add information about what DWO does and how to use it in README.md
  • Move configuration (dwoc) documentation under docs/dwo-configuration.md
  • Move development documentation in CONTRIBUTING.md

What issues does this PR fix or reference?

#1334

Is it tested? How?

The instructions in the new section have been tested on developer sandbox.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Copy link
Contributor

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, thank you!

README.md Outdated Show resolved Hide resolved
@dkwon17
Copy link
Collaborator

dkwon17 commented Nov 12, 2024

@l0rd sorry, could you add the fix in this commit I've added: 12b527f into a signed-off commit? I will merge this PR right after that.

@openshift-ci openshift-ci bot removed the lgtm label Nov 12, 2024
@l0rd
Copy link
Collaborator Author

l0rd commented Nov 12, 2024

@l0rd sorry, could you add the fix in this commit I've added: 12b527f into a signed-off commit? I will merge this PR right after that.

Thank you @dkwon17. I have included your change in the last commit of this PR.

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, ibuziuk, l0rd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17 dkwon17 merged commit fc6583d into devfile:main Nov 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants