Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parent dependency check on samples #397

Merged
merged 24 commits into from
May 28, 2024
Merged

Add parent dependency check on samples #397

merged 24 commits into from
May 28, 2024

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented May 14, 2024 •
edited
Loading

What does this PR do?:

Adds new script and new workflow to perform testing on child samples of stacks.

Which issue(s) this PR fixes:

fixes devfile/api#1142

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@michael-valdron michael-valdron mentioned this pull request May 14, 2024
Closed
4 tasks
@michael-valdron michael-valdron force-pushed the testing/check-parents branch 2 times, most recently from 6898fd1 to 518fdb2 Compare May 22, 2024 20:18
@michael-valdron
ignore cached remote samples
aced28b 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
nightly script for building sample parent stack list
da8dfc7 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
init check parent stacks script
cecd9ca 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
convert nightly parents build to on the fly parents build.
b19f793 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
multi version support for build parent stacks
804853f 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
ignore any local parents file.
c99a656 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
rename check_parent_stacks.sh to build_parents_file.sh, build_parents…
1d3f552 
…_file.sh now builds the parents yaml file and returns the children samples of the parent stacks.

Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
validate devfile schemas test suite parameters now changeable
a3092cb 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
validate samples workflow
50dfb62 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
add check for if there are samples to be checked under validate sampl…
6e8a981 
…es job.

Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
add README instruction on dependency check changes
b1a6ec7 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
yq 4.x installation guide link added to testing prerequisites list.
19004ef 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
add missing link to test suite
4a227ca 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
validate_devfile_schemas script accepts relative or absolute paths
46193a0 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
use registry-support cache samples
f45e89d 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
use yq v4.44.1
959bbce 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron michael-valdron force-pushed the testing/check-parents branch from 518fdb2 to 959bbce Compare May 22, 2024 20:31
@michael-valdron michael-valdron mentioned this pull request May 23, 2024
Closed
4 tasks
@michael-valdron michael-valdron force-pushed the testing/check-parents branch 3 times, most recently from 1678d0c to 0c6827c Compare May 23, 2024 22:18
@michael-valdron michael-valdron force-pushed the testing/check-parents branch from 0c6827c to a4ac51c Compare May 23, 2024 22:25
@michael-valdron michael-valdron marked this pull request as ready for review May 23, 2024 22:32
@michael-valdron michael-valdron requested a review from a team as a code owner May 23, 2024 22:32
@openshift-ci openshift-ci bot requested review from elsony and Jdubrick May 23, 2024 22:32
@michael-valdron michael-valdron changed the title [WIP]Add parent dependency check on samples Add parent dependency check on samples May 23, 2024
@michael-valdron
update README
a99d261 
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
Copy link
Member Author

Check Tools Provider

CI changes, N/A

@michael-valdron michael-valdron mentioned this pull request May 23, 2024
Closed
thepetk
thepetk reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good to me, left only some minor comments. Tested locally and it works. Very nice addition :)

tests/build_parents_file.sh Show resolved Hide resolved
tests/build_parents_file.sh Outdated Show resolved Hide resolved
tests/build_parents_file.sh Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
tests/validate_devfile_schemas.sh Outdated Show resolved Hide resolved
Jdubrick
Jdubrick reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. I pushed your branch to my own repo and tested the workflow and it works great! After changes Fanis suggested are made I think this is good to get approved

@AObuchow
Copy link

Just thinking out loud: the logic introduced in this PR could potentially be adopted to resolved #401 (comment) -- good timing :)

thepetk
thepetk approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm really helpful check!

@openshift-ci openshift-ci bot added the lgtm Looks good to me label May 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 66a5a95 into devfile:main May 28, 2024
11 checks passed
@michael-valdron michael-valdron mentioned this pull request May 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jdubrick Jdubrick Jdubrick approved these changes

@thepetk thepetk thepetk approved these changes

@elsony elsony Awaiting requested review from elsony

Assignees

@thepetk thepetk

@Jdubrick Jdubrick

Labels
approved lgtm Looks good to me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dependency check for current child samples
4 participants
@michael-valdron @AObuchow @thepetk @Jdubrick