Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: make crawls a first class feature #3319

Merged
merged 4 commits into from
Feb 10, 2025
Merged

feature: make crawls a first class feature #3319

merged 4 commits into from
Feb 10, 2025

Conversation

densumesh
Copy link
Contributor

Please indicate what issue this PR is related to and @ any maintainers who are relevant

@densumesh densumesh marked this pull request as draft February 5, 2025 21:39
@densumesh densumesh force-pushed the ds/better-crawl-options branch from e5ebfbd to 1dedd09 Compare February 10, 2025 06:18
@densumesh densumesh force-pushed the ds/better-crawl-options branch from 1dedd09 to c396d3b Compare February 10, 2025 06:24
@densumesh densumesh marked this pull request as ready for review February 10, 2025 06:26
@densumesh densumesh force-pushed the ds/better-crawl-options branch from c396d3b to 2fcde00 Compare February 10, 2025 06:41
skeptrunedev
skeptrunedev requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there's a migration which needs to be git add'ed here

@skeptrunedev skeptrunedev force-pushed the ds/better-crawl-options branch from 898a4e9 to a489a8c Compare February 10, 2025 07:38
@skeptrunedev skeptrunedev self-requested a review February 10, 2025 07:59
@densumesh densumesh changed the title feature: move crawl out of dataset and moved crawl_worker to broccoli feature: make crawls a first class feature Feb 10, 2025
@densumesh densumesh force-pushed the ds/better-crawl-options branch from e098ad9 to a6cd85f Compare February 10, 2025 08:11
@densumesh densumesh force-pushed the ds/better-crawl-options branch from a6cd85f to 6a061d8 Compare February 10, 2025 16:36
@skeptrunedev skeptrunedev merged commit 5c10a10 into main Feb 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeptrunedev skeptrunedev skeptrunedev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@densumesh @skeptrunedev