Task 1,2,3 and partially 4 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What: I completed task 1,2,3, and partially 4. How: I created a urls.py file in my article app, also updated the settings file to include the rest framework settings, and i also hid the secret key from public view using enviroment variables. To solve question 4, i added a models.PROTECT option to ensure when a tag is being deleted it is checked if an article is attached to it. If time were on my hand, I would using signals to implent the tag update check using the post_save method in signals. I also changed the generic views to Viewset to allow me flexibility. I could not complete my unit test because i clocked 2 hours
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I completed task 1,2,3, and partially 4.
How: I created a urls.py file in my article app, also updated the settings file to include the rest framework settings, and i also hid the secret key from public view using enviroment variables. To solve question 4, i added a models.PROTECT option to ensure when a tag is being deleted it is checked if an article is attached to it. If time were on my hand, I would using signals to implent the tag update check using the post_save method in signals. I also changed the generic views to Viewset to allow me flexibility. I could not complete my unit test because i clocked 2 hours