refactor: Use compressed storage #1
Conversation
oddaf
requested review from
0x3phemeralsoul
and removed request for
amusingaxl
| ``` | ||
| - Since rates are stored in 8 bytes, the max BPS that can be used without reimplementing this contract is **7891**. | ||
| - EIP-170: Due to contract size limits on Ethereum mainnet, the ceiling for rates is 6k. On L2s that do not enforce the limit this does not apply. | ||
| - Gas cost of deployment: With the current 30M block gas ceiling on Ethereum mainnet, up to ~5.5k rates can be stored. |
There was a problem hiding this comment.
does it make sense to translate 5.5K rates into bps? so from 0.01% until approx which bps would be possible, is it 50% approx? This would give a better idea of the technical limitation from a business sense
There was a problem hiding this comment.
In the end the limit is set 50% so we don't use the full 30M gas ceiling.
It means that it's every bps from 0 to 50%, a total of 50001 rates.
There was a problem hiding this comment.
The first ceiling is the block gas limit. It only allows rates until some number around 55%. I went with 50 because it's round (easy to remember) and I think going from it to 54.12 wouldn't make much difference in practice. But we could go there if needed. If the gas limit is raised we could go to the next ceiling (contract size, could go up to 6k rates)
test/Conv.t.sol
Outdated
| uint256 mappingRate = ratesMapping.rates(bps); | ||
| uint256 bytesRate = conv.turn(bps); | ||
|
|
||
| assertEq(bytesRate, mappingRate, string.concat("Rate mismatch at bps=", vm.toString(bps))); |
There was a problem hiding this comment.
how was ratesMapping created? is there a way to validate it fully matches: https://ipfs.io/ipfs/QmVp4mhhbwWGTfbh2BzwQB9eiBrQBKiqcPRZCaAxNUaar6 ?
Co-authored-by: amusingaxl <[email protected]> Signed-off-by: oddaf <[email protected]>
Co-authored-by: amusingaxl <[email protected]> Signed-off-by: oddaf <[email protected]>
Co-authored-by: amusingaxl <[email protected]> Signed-off-by: oddaf <[email protected]>
Co-authored-by: amusingaxl <[email protected]> Signed-off-by: oddaf <[email protected]>
Co-authored-by: amusingaxl <[email protected]> Signed-off-by: oddaf <[email protected]>
Co-authored-by: amusingaxl <[email protected]> Signed-off-by: oddaf <[email protected]>
Co-authored-by: amusingaxl <[email protected]> Signed-off-by: oddaf <[email protected]>
Co-authored-by: amusingaxl <[email protected]> Signed-off-by: oddaf <[email protected]>
No description provided.