Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Abilities not working after changing gamemode #890

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix Abilities not working after changing gamemode #890

wants to merge 2 commits into from
+3 −1

Conversation

UnknownOre
Copy link
Contributor

No description provided.

Sandertv
Sandertv reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really awful hack. Is there no other way to fix this that doesn't involve time.AfterFunc? How do other projects approach this?

@UnknownOre
Copy link
Contributor Author

This looks like a really awful hack. Is there no other way to fix this that doesn't involve time.AfterFunc? How do other projects approach this?

looks like other projects send the abilities next tick

@UnknownOre
Copy link
Contributor Author

we could send the abilities in the background task every x ticks, this what pm does here though PM has a system to mark attributes that need updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandertv Sandertv Sandertv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UnknownOre @Sandertv