Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add watchdog canister metadata #329

Merged
merged 9 commits into from
Sep 30, 2024
Merged

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Sep 23, 2024

This PR adds metadata to watchdog canister.

Additionally it adds candid compatibility test.

"./target/$TARGET/release/$CANISTER.wasm" \
-o "./target/$TARGET/release/$CANISTER.wasm" \
metadata candid:service -f "$SCRIPT_DIR/../canister/candid.did" -v public
./target/bin/ic-wasm \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here tabs were changed to spaces.

watchdog/Cargo.toml Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 23, 2024

canbench 🏋 (dir: .)

No significant performance changes detected ✅

./canbench_results.yml is up to date ✅

~/work/bitcoin-canister/bitcoin-canister/scripts ~/work/bitcoin-canister/bitcoin-canister
~/work/bitcoin-canister/bitcoin-canister

---------------------------------------------------

Benchmark: insert_300_blocks
  total:
    instructions: 561.73 M (-0.01%) (change within noise threshold)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: get_metrics
  total:
    instructions: 87.01 M (0.01%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers
  total:
    instructions: 3.90 B (0.00%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: insert_block_headers_multiple_times
  total:
    instructions: 13.90 B (0.02%) (change within noise threshold)
    heap_increase: 7 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: pre_upgrade_with_many_unstable_blocks
  total:
    instructions: 5.82 B (0.21%) (change within noise threshold)
    heap_increase: 4097 pages (no change)
    stable_memory_increase: 1792 pages (no change)

  serialize_blocktree (scope):
    instructions: 2.39 B (0.45%) (change within noise threshold)
    heap_increase: 2048 pages (no change)
    stable_memory_increase: 0 pages (no change)

  serialize_blocktree_flatten (scope):
    instructions: 201.60 K (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  serialize_blocktree_serialize_seq (scope):
    instructions: 2.39 B (0.45%) (change within noise threshold)
    heap_increase: 2048 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

@maksymar maksymar marked this pull request as ready for review September 23, 2024 15:10
@maksymar maksymar requested a review from a team as a code owner September 23, 2024 15:10
@maksymar maksymar changed the title feat: add watchdog canister metadata chore: add watchdog canister metadata Sep 23, 2024
@maksymar maksymar enabled auto-merge (squash) September 30, 2024 10:28
@maksymar maksymar merged commit 2cdc183 into master Sep 30, 2024
28 checks passed
@maksymar maksymar deleted the maksym/watchdog-metadata branch September 30, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants