New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move away from BigInt::try_into #458

Merged

chenyan-dfinity merged 1 commit into master from fix-bignum

Aug 3, 2023

Contributor

chenyan-dfinity commented Aug 3, 2023 •

edited

Loading

Some build target doesn't correctly identify try_into.

Fix #426


          move away from BigInt::try_into

c01bc2d

github-actions bot commented Aug 3, 2023

Benchmark for `f1484e0`

Click to view benchmark

Test	Base	PR	%
Blob/&str	344.5±163.32µs	356.6±146.00µs	+3.51%
Blob/ByteBuf	259.9±67.17µs	258.7±64.54µs	-0.46%
Blob/Bytes	190.8±67.09µs	203.5±64.37µs	+6.66%
Blob/String	415.4±159.89µs	432.9±165.02µs	+4.21%
Collections/vec (text, nat)	101.2±4.15ms	101.0±4.81ms	-0.20%
Collections/vec int	45.0±2.41ms	42.4±1.61ms	-5.78%
Collections/vec int64	25.7±1.83ms	26.9±1.58ms	+4.67%
Collections/vec nat8	18.2±1.09ms	18.0±0.84ms	-1.10%
option list/1024	1874.4±131.07µs	1915.8±151.35µs	+2.21%
profiles/1024	3.6±0.22ms	3.7±0.35ms	+2.78%
variant list/1024	1481.1±93.62µs	1501.0±103.59µs	+1.34%

rvanasa approved these changes

View reviewed changes

chenyan-dfinity merged commit 2c3f8a3 into master

3 checks passed

chenyan-dfinity deleted the fix-bignum branch

August 3, 2023 20:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet