Provide more accurate information as to why each task is in a specific state #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
778
to
787
| /* | ||
| // This is not an error condition anymore. | ||
| if (false) { | ||
| for (num, batch) in rollout.batches.iter() { | ||
| // This indicates a task pertaining to a batch was never processed. | ||
| for subnet in batch.subnets.iter() { | ||
| if subnet.state == SubnetRolloutState::Unknown { | ||
| error!(target:"frontend_api", "Subnet {} of batch {} in rollout {} was never processed by any task", subnet.subnet_id, num, rollout.name); | ||
| } | ||
| } |
There was a problem hiding this comment.
I will remove that. Thanks.
LittleChimera
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this (see tooltip).
Thanks to this, we fixed another couple of corner cases in subnet information display.