Task link fixed when tasks are in Deferred state. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whereas before we were updating the subnet link to the task when we updated the state, now we update the subnet link to point to the task logs when the actual state of the task corresponds to the expected state after updating. Since tasks are processed in topological order, the latest "active" task wins the link. What this does in effect is, e.g., if the rollout is waiting for a vote (`wait_for_revision_election` is in state `Deferred`), now we link to the task `wait_for_revision_election`, instead of its predecessor (in state `Complete`) task `create_proposal_if_none_exists`. This makes sense because the running task (`Deferred` is a form of running) is no longer the predecessor of `create_proposal_if_none_exists`. Will roll out later today.
… we treat states in other parts of the rollout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whereas before we were updating the subnet link to the task when we updated the state, now we update the subnet link to point to the task logs when the actual state of the task corresponds to the expected state after updating. Since tasks are processed in topological order, the latest "active" task wins the link.
What this does in effect is, e.g., if the rollout is waiting for a vote (
wait_for_revision_electionis in stateDeferred), now we link to the taskwait_for_revision_election, instead of its predecessor (in stateComplete) taskcreate_proposal_if_none_exists. This makes sense because the running task (Deferredis a form of running) is no longer the predecessor ofcreate_proposal_if_none_exists, and also as an operator you want to inspect the log of the currently running task, not the prior successfully finished one.Before:
After:
Will roll out later today.